Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded control's value not announced #1282

Closed
nvaccessAuto opened this issue Dec 18, 2010 · 7 comments
Closed

Embedded control's value not announced #1282

nvaccessAuto opened this issue Dec 18, 2010 · 7 comments
Labels
app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. app/firefox ARIA blocked/needs-external-fix bug close/worksforme p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority

Comments

@nvaccessAuto
Copy link

nvaccessAuto commented Dec 18, 2010 •
edited by jcsteh

Reported by simekk on 2010-12-18 17:36
This issue is relevant for components that are embedded in title HTML tag. Using the sample code form the the ARIA specification at
http://www.w3.org/TR/wai-aria/complete#tac_example2:

<input type="checkbox" id="flash">
  <label for="flash">
    Flash the screen  
    <input type="text" value="3" size="2" id="numTimes"
           aria-label="Number of times to flash screen">
    times
  </label>

The control is embedded and according to the algorithm specified here:
http://www.w3.org/TR/wai-aria/complete#textalternativecomputation
in part 2B, the embedded input text field should present its value. But it doesn't. Instead the title is spoken, which ruins the idea of reading the current value in title.

Expected: Flash the screen 3 times
I got: Flash the screen Number of times to flash screen times
("Number of times to flash screen" is a label)

Tested with IE8 or FF3.6.133 and leatest snapshot of NVDA
(JAWS 12 seems to handle this correctly but only with IE8)
@bhavyashah
Copy link

@jcsteh @feerrenrut Since this ticket seems to relate to ARIA, a key aspect of the ongoing Project Webfix, any thoughts/inputs?

@jcsteh jcsteh added ARIA p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Aug 6, 2017
@jcsteh
Copy link
Contributor

jcsteh commented Aug 6, 2017

I think there is an error in the original description, as it refers to the title tag, but I don't see how this is relevant. I'm guessing this was meant to refer to label. However, the point of the issue seems clear enough.

Quick test case: data:text/html,<input type="checkbox" id="flash"><label for="flash">Flash the screen <input type="text" value="5" aria-label="Number of times to flash screen"> times</label>

This still doesn't behave as expected in either Firefox or Chrome, but that needs to be fixed in the browsers. As for IE, there's no chance Microsoft will do anything, so we'd have to hack around it, which I don't think is something we will do given the difficulty in doing this and the ongoing demise of IE.

P3 to file bugs with Firefox and Chrome. Not something that hits users often in the wild as far as we know, so not a candidate for webfix.

@Adriani90
Copy link
Collaborator

@jcsteh is there already a bug filled with Mozilla?

@Adriani90
Copy link
Collaborator

Still reproducible with NVDA 2019.3 Beta 1, Firefox 71 and Chrome 79.

@aleventhal
Copy link

Fixed in Chrome Canary, starting tomorrow. See https://bugs.chromium.org/p/chromium/issues/detail?id=1121637

blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this issue Aug 27, 2020
@aleventhal
Name from label with embedded controls within
cc4fda9 
- Do not use author-supplied names of embedded controls
- Use the value from the embedded controls

See nvaccess/nvda#1282

Bug: 1121637
Change-Id: Ia4d175052c8279d10eec2d2e30f5d784c0b66d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374514
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802251}
@Adriani90
Copy link
Collaborator

Thanks very much for the update @aleventhal. Very appreciated. So this is now still reproducible in Edge Chromium 85 and Firefox 80. I will adjust the labels accodingly.

@Adriani90 Adriani90 added app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. and removed app/chrome labels Aug 31, 2020
@Adriani90
Copy link
Collaborator

Now the input value is spoken in all browsers, and in Firefox also the label and the input value is reported when focusing the checkbox.
Tested with
NVDA Version alpha-24876,2325be89

EdgeVersion 99.0.1150.30
Chrome Version 99.0.4844.51
Firefox Version 97.0.2

Closing as works for me.

mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this issue Oct 14, 2022
@aleventhal
Name from label with embedded controls within
b9632c6 
- Do not use author-supplied names of embedded controls
- Use the value from the embedded controls

See nvaccess/nvda#1282

Bug: 1121637
Change-Id: Ia4d175052c8279d10eec2d2e30f5d784c0b66d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374514
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802251}
GitOrigin-RevId: cc4fda9f1d43a2a4349f4c2b45ba6ac846e8292f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/edge/anaheim MS browser, chromium based, replaces Spartan in 2019 by Anaheim. NVDA access via IA2. app/firefox ARIA blocked/needs-external-fix bug close/worksforme p4 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@aleventhal @jcsteh @nvaccessAuto @bhavyashah @Adriani90