Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Braille messages no longer dismissed when a key press causes braille to update #1324

Closed
nvaccessAuto opened this issue Jan 17, 2011 · 1 comment
Closed

Braille messages no longer dismissed when a key press causes braille to update #1324

nvaccessAuto opened this issue Jan 17, 2011 · 1 comment
Assignees
@jcsteh
Labels
bug/regression bug component/braille
Milestone
2011.1

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2011-01-17 00:31
Braille messages are supposed to be dismissed automatically if a braille update was caused by a key press (90b8a72). However, the new input framework (062be1b) broke this, as this code relied on globalVars.keyCounter which is no longer updated. We need to either:

  • Find another way of determining when to dismiss messages automatically due to a user triggered braille update; or
  • Reinstate globalVars.keyCounter. I'd prefer to avoid this because I think keyCounter is fairly ugly and isn't used by anything else anymore.
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2011-01-19 07:11
For now, reinstated the key counter in c0391c7.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2011.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug/regression bug component/braille
Projects
None yet
Milestone
2011.1
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto