Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude unnecessary modules from py2exe bundle #1351

Closed
nvaccessAuto opened this issue Feb 3, 2011 · 2 comments
Closed

Exclude unnecessary modules from py2exe bundle #1351

nvaccessAuto opened this issue Feb 3, 2011 · 2 comments
Labels
close/wontfix enhancement

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2011-02-03 00:31
It seems there are quite a few unnecessary modules in our py2exe bundle (library.zip); e.g. distutils, email, unittest, BaseHTTPServer, etc. It's possible that some of these modules are unconditionally imported, in which case there is nothing we can do. However, py2exe does include modules that are conditionally imported, so it's possible that quite a few of them aren't actually ever used. We should figure out which ones aren't used and exclude them so they don't waste space.
@LeonarddeR
Copy link
Collaborator

@jcsteh: seems that this is still a valid issue, but it probably doesn't have much priority due to the abandoned state of this.

Since we are talking about library.zip here, I wonder, is it possible for people to inject malicious modules in this file? Or is there some hidden place where Py2exe checks for md5sums or the like on library.zip?

@jcsteh
Copy link
Contributor

jcsteh commented Jul 18, 2017

@leonardder commented on 15 Jul 2017, 19:30 GMT+12:

@jcsteh: seems that this is still a valid issue, but it probably doesn't have much priority due to the abandoned state of this.

Agreed. If anything, people want more modules rather than less and the space gain from doing this is probably minimal, so not much point in investing resources into it.

Since we are talking about library.zip here, I wonder, is it possible for people to inject malicious modules in this file? Or is there some hidden place where Py2exe checks for md5sums or the like on library.zip?

I don't think there is. Ideally, there should be. This should be filed as a separate issue.

Closing.

@jcsteh jcsteh closed this as completed Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
close/wontfix enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@LeonarddeR @jcsteh @nvaccessAuto