New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render aria-label in browse mode when it is used to override content #1354
Comments
Comment 1 by jteh on 2011-02-04 21:26 |
Comment 2 by aleksey_s (in reply to comment description) on 2011-02-04 21:35
I am not sure that announcing label inline is convenient, esp. for mathematical expressions user might want to navigate it character by character or similarly. So it should be rendered in to buffer as a text. |
Comment 3 by courtney.christensen@... (in reply to comment 2) on 2011-02-04 21:42
That's an ''excellent'' point. In fact, that's one of the bigger accessibility issues we deal with when it comes to math expressions. Descriptions of math equations can quickly become very long and difficult to visualize. Please forgive my ignorance in the way this text is structured in memory -- you're spot on. |
Comment 4 by aleksey_s on 2011-02-04 21:54 |
Comment 5 by courtney.christensen@... (in reply to comment 4) on 2011-02-04 22:12
Well I'll be...it sure does! However, it doesn't as soon as I add a text child. The following (stupid example) reads "x equals zero point two five" (IE ''only''):
Yet this does not:
This actually seems like intentional behavior on the part of NVDA, but I have only a cursory knowledge of NVDA. It should be noted that neither example speaks the label in Firefox (4.0b10) or Chrome (9.0.597.84). Not sure if I'm helping here... |
Comment 6 by jteh on 2011-07-07 10:13 |
Comment 7 by jteh on 2012-06-20 03:19 and tags" to "Render aria-label in browse mode when it is used to override content"
|
Comment 9 by parham on 2012-06-20 04:45 |
Comment 10 by jteh on 2012-08-31 06:08 |
Comment 11 by jteh on 2012-10-19 01:15 |
Comment 12 by jteh on 2013-03-20 02:12 |
Comment 13 by jteh on 2013-04-24 01:48 |
Comment 14 by jteh on 2013-06-26 02:55 |
Comment 15 by parham (in reply to comment 13) on 2013-10-07 09:57
I'm not sure about the proper channels for doing this, but is it possible for the author to explicitly say that the label overrides the content? Look at the below code as an example. The character between the opening and closing "a" tag is a UTF-8 icon that doesn't make sense to eSpeak (and when eSpeak doesn't read it, I'm not sure if anything would, lol):
This would definitely need the "Settings" aria label to make sense, although the content inside is... well, something. |
Comment 16 by jteh (in reply to comment 15) on 2013-10-07 16:35
Not at present; that's the problem here.
That character is in the Unicode private use area. There was some talk of overriding content with the label for such characters, which might solve this case. Btw, while I generally oppose aria-hidden, here's a possible work around for this case:
|
Comment 17 by jteh on 2013-11-27 06:21 |
Comment 18 by jteh on 2014-02-14 08:54 Aria-label(ledby) still won't override the content for spans and divs because this would break labelled landmarks, regions, etc. |
Comment 19 by jteh on 2014-02-14 08:55 |
Comment 21 by MarcoZehe on 2014-02-15 05:40 |
Comment 23 by James Teh <jamie@... on 2014-02-17 03:41
Changes:
|
Comment 25 by James Teh <jamie@... on 2014-03-10 04:54
Changes:
|
Comment 26 by jteh on 2014-03-10 04:56 |
Without this change screen readers in browse mode [1] will incorrectly read errors and warnings that have a tooltip of "42 errors, 99 warnings" as "4299". After this change screen readers will announce the same content as the shown in the tooltip: "42 errors, 99 warnings". Because errors and warnings are indicated with icons this change will fix the screen reader bug and helps meet success criteria for WCAG 1.1.1 Non-text Content [2]. Root cause: The icons do not have accessible names and screen readers will combine the content of the spans: <span><error-icon/>42<span><span><warning-icon/>99</span> is announced as 4299 The fix: * Set the accessible name of counter element (title alone is insufficient [3]). * Make the children of the counter hidden otherwise NVDA (and JAWs) screen readers will ignore the aria-label [4]. [1]: https://www.nvaccess.org/files/nvda/documentation/userGuide.html#BrowseMode [2]: https://www.w3.org/WAI/WCAG21/quickref/#non-text-content [3]: https://crrev.com/18d41172/third_party/blink/renderer/devtools/front_end/ui/Tooltip.js#190 [4]: nvaccess/nvda#1354 (comment) Screenshot (NVDA speech viewer): https://i.imgur.com/KznR7O7.png screen reader should announce the number of errors and warnings. Test: Navigate to the counter in NVDA browse mode on Win10 and the Bug: 963183 Change-Id: I46985e223a6f8bac5cd1dbdf597a4b0c9ab71567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861214 Reviewed-by: Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Original-Commit-Position: refs/heads/master@{#707031} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 5814dabc5bfa705994cea056b539243789e481c9
Without this change screen readers in browse mode [1] will incorrectly read errors and warnings that have a tooltip of "42 errors, 99 warnings" as "4299". After this change screen readers will announce the same content as the shown in the tooltip: "42 errors, 99 warnings". Because errors and warnings are indicated with icons this change will fix the screen reader bug and helps meet success criteria for WCAG 1.1.1 Non-text Content [2]. Root cause: The icons do not have accessible names and screen readers will combine the content of the spans: <span><error-icon/>42<span><span><warning-icon/>99</span> is announced as 4299 The fix: * Set the accessible name of counter element (title alone is insufficient [3]). * Make the children of the counter hidden otherwise NVDA (and JAWs) screen readers will ignore the aria-label [4]. [1]: https://www.nvaccess.org/files/nvda/documentation/userGuide.html#BrowseMode [2]: https://www.w3.org/WAI/WCAG21/quickref/#non-text-content [3]: https://crrev.com/18d41172/third_party/blink/renderer/devtools/front_end/ui/Tooltip.js#190 [4]: nvaccess/nvda#1354 (comment) Screenshot (NVDA speech viewer): https://i.imgur.com/KznR7O7.png screen reader should announce the number of errors and warnings. Test: Navigate to the counter in NVDA browse mode on Win10 and the Bug: 963183 Change-Id: I46985e223a6f8bac5cd1dbdf597a4b0c9ab71567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861214 Reviewed-by: Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#707031}
Reported by courtney.christensen@... on 2011-02-04 21:19
The
aria-label
attribute is currently not recognized on structural HTML elements such as<div>
and<span>
elements. There are many cases in which this would be valuable. For example, MathJax transcribes MathMLalttext
into a<span>
element with anaria-label
:Presently, NVDA ignores the
aria-label
and speaks the contents as text.I propose the alternate text be announced "inline", much in the way landmarks are announced. If the child content is not relevant to the screen-reader, it is up to the content author to prevent it from being spoken (though
aria-hidden
or a similar mechanism).Blocking #1195, #1362, #3551, #3852, #3889
The text was updated successfully, but these errors were encountered: