Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language SR in general settings incorrectly labelled #1363

Closed
nvaccessAuto opened this issue Feb 11, 2011 · 6 comments
Closed

Language SR in general settings incorrectly labelled #1363

nvaccessAuto opened this issue Feb 11, 2011 · 6 comments
Labels
bug
Milestone
2013.1

Comments

@nvaccessAuto
Copy link

Reported by briang1 on 2011-02-11 15:04
Language (requires restart to fully take affect): English (United Kingdom), sr
This is what I see on this item in the general settings language selection. If I select this it is most certainly not English!

Apparently, others with different default languages get their own language in this position instead.
Evem if you rename folder SR to something no containing SR its still picked yup as the above.
Weird
There was no SR in 2010.2 so it never cropped up there.

Note all snaps and the latest beta are showing the problem.
@nvaccessAuto
Copy link
Author

Comment 1 by mdcurran on 2011-02-12 04:57
Half fixed in b56a574. Now at least its only reported as "sr", not ", sr".
Further fixes can be made to possibly get the correct label for sr, but not for 2011.1.
Some notes:
in languageHandler.localeNameToWindowsLCID: we always use locale.normalize to normalize the locale name. However, the function in Windows vista and above that can convert locale names to LCIDs does not support sr-RS (which is what sr is normalized to). Yet it does seem to support sr by itself, returns serbian (latin)... is this correct?
We should probably only normalize the locale name if falling back to using locale.windows_locale, rather than for both that and Vista/7 lookup function.

@nvaccessAuto
Copy link
Author

Comment 2 by mdcurran on 2011-02-12 04:57
Changes:
Milestone changed from None to near-term

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2011-12-27 00:44
Another fix in 501a6f1. Now sr is labeled correctly in Vista and above, by making the above noted change.

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2012-01-06 06:36
Can this ticket be closed now or are there still outstanding issues?

@nvaccessAuto
Copy link
Author

Comment 5 by briang1 on 2012-01-06 07:22
In XP SR is now just blank, ie it does not have any language description. if SR is the only one maybe it can be hard coded in some way?

@nvaccessAuto
Copy link
Author

Comment 6 by mdcurran on 2012-12-10 06:13
sr is now labeled correctly in XP as of 4b1e743.
Changes:
Milestone changed from near-term to 2013.1
State: closed

@nvaccessAuto nvaccessAuto added this to the 2013.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2013.1
Development

No branches or pull requests
1 participant
@nvaccessAuto