Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Say all is broken for akelpad #1365

Closed
nvaccessAuto opened this issue Feb 12, 2011 · 6 comments
Closed

Say all is broken for akelpad #1365

nvaccessAuto opened this issue Feb 12, 2011 · 6 comments

Comments

@nvaccessAuto
Copy link

Reported by aleksey_s on 2011-02-12 08:29
str:

test line 1
test line 2
  • while on a first line, press NVDA+downArrow

Current results:
NVDA stops on line 1.

Expected results:
NVDA should proceed with line 2.

additional info:
This doesn't occur with akelpad 4.3.3, an old version I was using until recent.

@nvaccessAuto
Copy link
Author

Comment 1 by aleksey_s on 2011-02-12 08:30
This is a regression caused by recent akelpad support code changes.

Marking as major, since akelpad is widely used throughout Russian Community.

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2011-02-12 09:41
Hmm. The new version of !AkelPad seems to be problematic in general. If this can't be fixed easily, we should just revert the initial fix and defer both issues to 2011.2. That way, there's no regression in NVDA itself. I'd rather not delay the release for this, though there is still a few weeks left.

@nvaccessAuto
Copy link
Author

Comment 4 by aleksey_s (in reply to comment 3) on 2011-02-12 10:18
Replying to jteh:

Hmm. The new version of !AkelPad seems to be problematic in general.

Have you discovered anything specific?

@nvaccessAuto
Copy link
Author

Comment 5 by pvagner on 2011-02-14 09:44
We must definatelly fix this.
The thing is I have only changed function _getLineOffsets() which now has bug.
It always returns end of line minus 1.
If I fix that sayall is still broken.
Do you have any hints?

@nvaccessAuto
Copy link
Author

Comment 6 by pvagner on 2011-02-14 10:01
okay, I've found the problem.
It's my n000bness.
I've implemented that function so it works with the current carret position ignoring the offset parameter.

@nvaccessAuto
Copy link
Author

Comment 7 by pvagner on 2011-02-14 10:34
Fixed in changeset:releases/2011.1,4112
Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant