New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentence endings aren't preserved in notepad #1462
Comments
Comment 1 by jteh on 2011-04-18 09:55
That shows that the question mark is definitely being preserved. Note that the null character immediately following the question mark (which edit fields output at the end of each line) might be affecting the output from the synth. We should perhaps consider stripping those. This would perhaps also explain the difference between the two editors. |
Comment 2 by aleksey_s on 2011-04-18 13:28 |
Comment 3 by briang1 on 2011-04-18 15:07 |
Comment 4 by jteh on 2011-04-18 23:15 |
Comment 5 by jteh on 2011-04-18 23:26 |
Comment 6 by jteh on 2011-04-19 00:23 Looks like the null character is affecting the sentence ending rule. However, this would have been the same in 2011.1.1. What symbol level are you using? In 2011.1.1, what did you have speak punctuation set to? |
Comment 7 by jteh on 2011-04-19 01:51 |
Comment 8 by aleksey_s (in reply to comment 6) on 2011-04-19 06:01
I do not have 2001.1.1 installed here, I use latest NVDA from sources all the time. I can confirm that the regression is here after recent merge. Also, I checked with 2010.1 (which I suddenly have in program files) to see that both synths behave as expected in described situation. |
Comment 9 by jteh on 2011-04-19 07:22 What did you have speak punctuation set to when testing with the older code? Here, if I set speak punctuation to on (with older code), the question mark is not preserved in Notepad unless I put a space after the question mark. Thus, this isn't actually a regression in that case. However, if I set speak punctuation to off, it is preserved because we just send unprocessed punctuation to the synth in that case. |
Comment 10 by mdcurran on 2011-04-25 04:08 |
Comment 11 by aleksey_s on 2011-04-25 08:18 |
Comment 12 by briang1 on 2011-04-25 12:20 |
Reported by aleksey_s on 2011-04-18 09:39
str:
Current results:
NVDA speaks the line as there is no question mark at the end
Expected results:
NVDA should preserve question mark.
Additional info:
Works as expected in akelpad.
The text was updated successfully, but these errors were encountered: