Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fourth column of symbols.dic cannot be edited in new Symbol Pronunciation GUI. #1530

Closed
nvaccessAuto opened this issue May 27, 2011 · 4 comments

Comments

@nvaccessAuto
Copy link

Reported by elliott94 on 2011-05-27 20:36
The pauses that should be honoured when symbols such as parentheses and em-dashes are encountered only occur when a fourth column is (manually) added to symbols.dic and set to the value of "Always." This cannot be achieved at this time while using the new "Punctuation/Symbol Pronunciation" dialog.

@nvaccessAuto
Copy link
Author

Comment 1 by elliott94 on 2011-05-27 20:44
Changes:
Changed title from "Pauses arn't added when editing symbols when using the new GUI interface" to "Fourth column of symbols.dic cannot be edited in new Symbol Pronunciation GUI."

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2011-05-28 07:02
The effect of preserving the symbol depends on the symbol. It may not necessarily cause a pause. In fact, it could cause the synth to read the symbol itself, thus doubling up. Most users aren't going to understand the concept of symbol preservation. I'm tempted to wontfix this on these grounds. Users who really want it can still edit the file. Mick, thoughts?

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2011-05-28 09:31
I think I see the symbol GUI mearly as a way that users can rename or silence/announce symbols. I don't think it must be a GUI for the full feature set of symbol processing. As Jamie has stated, the file is there for those to edit.
I'm happy with all it allows right now. No need for preservation.
having said this, if someone was to provide a patch adding the appropriate controls, and code to interface with characterProcessing, and also provided a good enough explination that could be used directly in user documentation that clearly told users what the setting does, then I'm not sure I'd refuse the addition. But, I think for now its won't fix, at least from the lead developers.

@jcsteh
Copy link
Contributor

jcsteh commented Sep 7, 2016

This was done in #5234.

@jcsteh jcsteh closed this as completed Sep 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants