Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: Text of toggle buttons not announced. #1626

Closed
nvaccessAuto opened this issue Jun 29, 2011 · 9 comments
Closed

Firefox: Text of toggle buttons not announced. #1626

nvaccessAuto opened this issue Jun 29, 2011 · 9 comments

Comments

@nvaccessAuto
Copy link

Reported by kevinchao89 on 2011-06-29 20:04
Firefox 7.0a1 (2011-06-29) and NVDA Snapshot 4511.

  1. Open
    http://archive.dojotoolkit.org/nightly/dojotoolkit/dijit/tests/form/test_Button.html
  2. press h until you reach the heading that says "toggle buttons".
  3. press B to move to the first button.
  4. press the SPACEBAR or enter on the first button and NVDA should announce the new text on the button as it changes but it does not.
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2011-06-29 23:58
The text of the button doesn't actually change. However, the button changes from a normal button to a toggle button and gains the pressed state.

This is rather odd; an object really shouldn't change its role like that. This needs further investigation.
Changes:
Milestone changed from None to near-term

@nvaccessAuto
Copy link
Author

Comment 2 by nvdakor on 2014-12-18 16:05
Hi all,
This is still the case in IE11 and Firefox 33. Thanks.

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2015-05-04 03:25
The button in the testcase is always a toggle button in Firefox now. NVDA announces the pressed state as it gets added. NVDA does not however announce the name/text of the button when it changes, but nor does NVDA do this for any other name/text in browse mode. I.e. this is not specific to toggle buttons.

@nvaccessAuto
Copy link
Author

Comment 4 by mdcurran on 2015-05-08 02:17
It seems that Mozilla Gecko does not fire a nameChange event for this toggle button when pressed, thus NVDa is not notified of the name change. It looks like Gecko will fire a name change in situations where the name comes directly from an attribute on the node (i.e. aria-label, title etc), but not indirectly (descendant calcuation, aria-labelledby etc). Therefore Until Gecko implements nameChange events for descendant calculation (which could be rather costly), you could for now set aria-label on the node, changing it as the button's text changes. Or, use aria-live on the button.

@nvaccessAuto nvaccessAuto added this to the near-term milestone Nov 10, 2015
@jcsteh jcsteh removed this from the near-term milestone Jun 24, 2016
@LeonarddeR
Copy link
Collaborator

CC @michaelDCurran @josephsl @jcsteh

@jcsteh
Copy link
Contributor

jcsteh commented Jul 19, 2017

Still not fixed. Mozilla bug needs to be filed.

@jcsteh jcsteh removed their assignment Sep 5, 2017
@Adriani90
Copy link
Collaborator

Is there a Mozilla bug for this in place?

@jcsteh
Copy link
Contributor

jcsteh commented Jul 15, 2018

Firing name change events due to descendant changes is covered by Mozilla bug 1422913. Name change events for other cases is covered by Mozilla bug 493683. I think the latter is most appropriate to this test case; I think it's using aria-labelledby. Both are difficult to fix without performance penalties and aren't a big problem in real world usage, which is why this hasn't been fixed yet.

@jcsteh
Copy link
Contributor

jcsteh commented Jan 29, 2021

Fixed in Firefox 87 (currently Nightly).

@jcsteh jcsteh closed this as completed Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants