Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog role not announce when dialog contains ARIA document #1675

Closed
nvaccessAuto opened this issue Jul 15, 2011 · 4 comments
Closed

Dialog role not announce when dialog contains ARIA document #1675

nvaccessAuto opened this issue Jul 15, 2011 · 4 comments
Assignees
@michaelDCurran
Labels
bug feature/browse-mode
Milestone
2011.3

Comments

@nvaccessAuto
Copy link

Reported by kloots on 2011-07-15 17:17
We've added a dialog to Yahoo! Mail that exposes all of the keyboard shortcuts for the application. The shortcuts are marked up as a set of definition lists, so I've placed a role of document on the

containing all of the lists so that users can navigate the dialog content using the virtual cursor.

When we display the dialog, I set focus to the element with the role of document. NVDA will begin announcing the content of the document when the dialog is made visible, but it never announces the dialog role which is applied to one of the ancestor nodes of the document.

I thought that it'd be important that the user knows they're in a dialog - so that they know to press Esc to return to the application.

To reproduce the bug:

  1. Go to http://web32397.mail.mud.yahoo.com/neo/launch
  2. Login using the following credentials:
    Username: neo_access_us1
    Password: testing
  3. After logging in press Shift + ? to launch the keyboard shortcuts dialog
@nvaccessAuto
Copy link
Author

Comment 1 by kevinchao89 (in reply to comment description) on 2011-07-15 18:15
Confirmed 100% with NVDA snapshot 4560 and Firefox Nightly 8.0a1 (2011-07-14). Dialog roll is not announced at all.

As a side note: It's not possible to press ENTER on any of the shortcuts nor is it possible to press the different hot-keys (NVDA HTML commands are issued instead).

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2011-07-16 10:09
This is caused by speech being cancelled before the say all when a virtual buffer first gets focused. If we remove this, we need to be careful of excessive verbosity.
Changes:
Milestone changed from None to 2011.3

@nvaccessAuto
Copy link
Author

Comment 4 by mdcurran on 2011-09-09 02:43
Fixed in b822ea0.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 5 by kevinchao89 on 2011-09-09 13:47
Thanks! Confirmed fixed in Snapshot Main-4568. Excellent!

@nvaccessAuto nvaccessAuto added this to the 2011.3 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelDCurran michaelDCurran

Labels
bug feature/browse-mode
Projects
None yet
Milestone
2011.3
Development

No branches or pull requests
2 participants
@michaelDCurran @nvaccessAuto