Opened 3 years ago

Closed 22 months ago

#2236 closed enhancement (fixed)

Add support for Comodo Dragon

Reported by: ashleycox Owned by:
Priority: trivial Milestone: 2013.1
Component: Browse mode Version: master
Keywords: Cc:
Operating system: Blocked by:
Blocking:
Changes document entry (for developers):

Description

Comodo dragon is a web browser based on Google chrome, though with a few nice features and enhancements. While NVDA does read certain parts of the browser, (it can read the location bar, teh menu bar, and can navigate pages using object nav and the tab key), support needs to be implemented to:
Read pages in the normal way (using the arrows and standard navigation commands).
Access the 2 toolbar buttons (the share button and site inspector).
and that's about it - for the most part, it works.

Attachments (3)

App_Modules.zip (2.4 KB) - added by ateu 2 years ago.
App modules for Comodo Dragon, SRWare Iron and Rockmelt. Works fine!
dragon.py (274 bytes) - added by ateu 2 years ago.
Updated copyright year
appModules.7z (682 bytes) - added by ateu 22 months ago.
Attaching the 4 appmodules in order to facilitate when commiting.

Download all attachments as: .zip

Change History (18)

comment:1 Changed 3 years ago by jteh

  • Operating system Windows 7 deleted
  • Priority changed from minor to trivial

comment:2 Changed 2 years ago by ateu

In Comodo Dragon, as well as in SRWare Iron and Rockmelt, is not possible to use the caret.
When using the focus, all controls focused are correctly read. Also it's possible to edit when on a edit field.
I do not understand why being chrome based, this browser has this problems.

comment:3 Changed 2 years ago by ateu

Interestingly, the coolnovo, another chrome based browser works really fine like chrome with NVDA. The only one difference is that it's necessary to use flat review to install it. Once installed, no more problems.
In comodo dragon, as well as srware iron, only it's possible to use the focus.
I'm mentioning srware iron as it has exactly the same problem.

Do you think the accessibility APIs are present in this browsers?

Changed 2 years ago by ateu

App modules for Comodo Dragon, SRWare Iron and Rockmelt. Works fine!

comment:4 Changed 2 years ago by ateu

I've attached App Modules to NVDA works with Comodo Dragon, SRWare Iron and Rockmelt, another chrome based browser, with native support for facebook and other services.
I just renamed chrome.py, with the name of the executable instead of chrome.

Last edited 2 years ago by ateu (previous) (diff)

comment:5 Changed 2 years ago by ateu

Unfortunately, it's not possible to open the comodo menu using alt key, but only using object navigation and moving mouse to the menu button and performing a left click.

Last edited 2 years ago by ateu (previous) (diff)

comment:6 Changed 2 years ago by ateu

Jamie,

Is it possible to add a class in chrome.py so that it works with this browsers which I've mentioned or creating a separate appmodule is the only one way?

comment:7 follow-up: Changed 2 years ago by jteh

An app module is only loaded based on the executable name, so each executable needs its own app module. However, rather than copying the code for each app, you only need one line of code:

from .chrome import *

comment:8 in reply to: ↑ 7 Changed 2 years ago by ateu

Replying to jteh:

An app module is only loaded based on the executable name, so each executable needs its own app module. However, rather than copying the code for each app, you only need one line of code:

from .chrome import *

Thanks. Living and learning.

And is there something to do in order to makes possible get menu with alt key, or is this a bug on this app?

Last edited 2 years ago by ateu (previous) (diff)

comment:9 Changed 2 years ago by ateu

The comodo menu is opened by pressing alt+f or alt+e.
However, pressing alt the menu is not opened.
I don't know whether this is a difference or a lake of accessibility.

Changed 2 years ago by ateu

Updated copyright year

comment:10 Changed 23 months ago by ateu

Hi

All chrome based browsers has another menu, a tool bar, which can be accessed by pressing tab after the main menu is opened with alt key.
Although it's possible to open the comodo's main menu by pressing alt+f or alt+e, we cannot tab to the second menu.
Only it's possible to access this menu via object navigation.
In this menu, there is options to save, reload, manage add-ons, etc.

Do you think this can be fixed by NVDA?

Thanks

Last edited 23 months ago by ateu (previous) (diff)

comment:11 Changed 22 months ago by MHameed

If i understood this correctly, this ticket and #2813, #2814 and #2815 are all the same and just need the one line include to make them accessible (to the same level as crome is)?
If so should these one line appmodules be committed for 2013.1?
Thanks.

comment:12 Changed 22 months ago by jteh

I'm happy for them to be committed if someone else wants to do it. :) They need a What's New entry as well (probably just one entry for all of them).

Changed 22 months ago by ateu

Attaching the 4 appmodules in order to facilitate when commiting.

comment:13 Changed 22 months ago by ateu

Hi

Mesar, can you commit this?
I've also added a text file containing a possible what's new entry.
Furgive me for my bad English.

comment:14 Changed 22 months ago by MHameed

changeset,main:5928
Thanks.

comment:15 Changed 22 months ago by MHameed

  • Milestone set to 2013.1
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.