Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Comodo Dragon #2236

Closed
nvaccessAuto opened this issue Apr 11, 2012 · 17 comments
Closed

Add support for Comodo Dragon #2236

nvaccessAuto opened this issue Apr 11, 2012 · 17 comments

Comments

@nvaccessAuto
Copy link

Reported by ashleycox on 2012-04-11 09:55
Comodo dragon is a web browser based on Google chrome, though with a few nice features and enhancements. While NVDA does read certain parts of the browser, (it can read the location bar, teh menu bar, and can navigate pages using object nav and the tab key), support needs to be implemented to:
Read pages in the normal way (using the arrows and standard navigation commands).
Access the 2 toolbar buttons (the share button and site inspector).
and that's about it - for the most part, it works.

@nvaccessAuto
Copy link
Author

Comment 2 by ateu on 2012-10-01 15:47
In Comodo Dragon, as well as in SRWare Iron and Rockmelt, is not possible to use the caret.
When using the focus, all controls focused are correctly read. Also it's possible to edit when on a edit field.
I do not understand why being chrome based, this browser has this problems.

@nvaccessAuto
Copy link
Author

Comment 3 by ateu on 2012-11-17 02:27
Interestingly, the coolnovo, another chrome based browser works really fine like chrome with NVDA. The only one difference is that it's necessary to use flat review to install it. Once installed, no more problems.
In comodo dragon, as well as srware iron, only it's possible to use the focus.
I'm mentioning srware iron as it has exactly the same problem.

Do you think the accessibility APIs are present in this browsers?

@nvaccessAuto
Copy link
Author

Attachment App_Modules.zip added by ateu on 2012-11-19 21:31
Description:
App modules for Comodo Dragon, SRWare Iron and Rockmelt. Works fine!

@nvaccessAuto
Copy link
Author

Comment 4 by ateu on 2012-11-19 21:37
I've attached App Modules to NVDA works with Comodo Dragon, SRWare Iron and Rockmelt, another chrome based browser, with native support for facebook and other services.
I just renamed chrome.py, with the name of the executable instead of chrome.

@nvaccessAuto
Copy link
Author

Comment 5 by ateu on 2012-11-23 10:19
Unfortunately, it's not possible to open the comodo menu using alt key, but only using object navigation and moving mouse to the menu button and performing a left click.

@nvaccessAuto
Copy link
Author

Comment 6 by ateu on 2012-12-09 21:39
Jamie,

Is it possible to add a class in chrome.py so that it works with this browsers which I've mentioned or creating a separate appmodule is the only one way?

@nvaccessAuto
Copy link
Author

Comment 7 by jteh on 2012-12-09 23:20
An app module is only loaded based on the executable name, so each executable needs its own app module. However, rather than copying the code for each app, you only need one line of code:

from .chrome import *

@nvaccessAuto
Copy link
Author

Comment 8 by ateu (in reply to comment 7) on 2012-12-10 00:17
Replying to jteh:

An app module is only loaded based on the executable name, so each executable needs its own app module. However, rather than copying the code for each app, you only need one line of code:

from .chrome import *

Thanks. Living and learning.

And is there something to do in order to makes possible get menu with alt key, or is this a bug on this app?

@nvaccessAuto
Copy link
Author

Comment 9 by ateu on 2013-01-13 01:36
The comodo menu is opened by pressing alt+f or alt+e.
However, pressing alt the menu is not opened.
I don't know whether this is a difference or a lake of accessibility.

@nvaccessAuto
Copy link
Author

Attachment dragon.py added by ateu on 2013-01-13 10:41
Description:
Updated copyright year

@nvaccessAuto
Copy link
Author

Comment 10 by ateu on 2013-02-01 10:40
Hi

All chrome based browsers has another menu, a tool bar, which can be accessed by pressing tab after the main menu is opened with alt key.
Although it's possible to open the comodo's main menu by pressing alt+f or alt+e, we cannot tab to the second menu.
Only it's possible to access this menu via object navigation.
In this menu, there is options to save, reload, manage add-ons, etc.

Do you think this can be fixed by NVDA?

Thanks

@nvaccessAuto
Copy link
Author

Comment 11 by MHameed on 2013-03-02 18:28
If i understood this correctly, this ticket and #2813, #2814 and #2815 are all the same and just need the one line include to make them accessible (to the same level as crome is)?
If so should these one line appmodules be committed for 2013.1?
Thanks.

@nvaccessAuto
Copy link
Author

Comment 12 by jteh on 2013-03-02 23:43
I'm happy for them to be committed if someone else wants to do it. :) They need a What's New entry as well (probably just one entry for all of them).

@nvaccessAuto
Copy link
Author

Attachment appModules.7z added by ateu on 2013-03-03 00:20
Description:
Attaching the 4 appmodules in order to facilitate when commiting.

@nvaccessAuto
Copy link
Author

Comment 13 by ateu on 2013-03-03 00:22
Hi

Mesar, can you commit this?
I've also added a text file containing a possible what's new entry.
Furgive me for my bad English.

@nvaccessAuto
Copy link
Author

Comment 14 by MHameed on 2013-03-03 06:11
changeset,main:5928
Thanks.

@nvaccessAuto
Copy link
Author

Comment 15 by MHameed on 2013-03-03 06:16
Changes:
Milestone changed from None to 2013.1
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant