New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with reading of selected text in Eclipse code editor #2314
Comments
Comment 1 by isaacporat on 2013-12-18 07:57 |
Comment 3 by jteh on 2014-09-24 04:53 I don't have time to learn how to use Eclipse right now, but it seems I'm the only one able/willing to debug this. Therefore, in order to make this faster, it'd be great if someone could provide thorough steps to reproduce, including the steps to create an appropriate project/file/whatever to reproduce the problem. From memory, I tried to reproduce this in a simple plain text editor in Eclipse and couldn't reproduce it. Thanks. |
Comment 4 by parham (in reply to comment 3) on 2014-09-24 05:43
It's quite simple, really.
You said NVDA worked fine for you in text files, so I'm assuming you've already taken the steps above. This is just to make sure we're going through the same steps. If so, please let me know how I can help you in debugging it so that I can do it on my own machine. Note that I've been using Eclipse-based editors for a year and a half with all NVDA versions in between. This issue is not new and has always been there. |
Comment 7 by jteh on 2014-10-10 07:30 Technical: The problem is that Eclipse fires a valueChange event on the editable text field whenever the selection changes. It really shouldn't do this, since the value (the text) didn't change. NVDA interprets this as a text change, and because you can't reliably speak selection changes when the text changes, we speak the entire selection. The correct fix is for Eclipse to stop firing the valueChange event for selection. However, we'll probably need to work around this in NVDA in the interim. |
Comment 8 by parham (in reply to comment 7) on 2014-10-10 07:45
Dang. It's not the first time Eclipse is firing wrong events. I'm sorry that you have to code all of these workarounds. |
Comment 9 by jteh on 2014-10-10 07:54 |
Comment 10 by James Teh <jamie@... on 2014-10-10 08:13
|
Comment 11 by James Teh <jamie@... on 2014-10-10 08:14
Changes:
|
Comment 12 by James Teh <jamie@... on 2014-10-26 22:02
Changes:
|
Comment 13 by jteh on 2014-10-26 22:03 |
Reported by mjs on 2012-05-09 23:41
I am having an issue with the reading of selected text in the Eclipse code editor.
To reproduce:
Open a new file and enter a few lines of text.
line one
line two
line three
line four
Select the first line of text and NVDA reports "selected line one"
Still holding down shift arrow down to select the next line and NVDA reports "selected line one line two"
So rather than just announcing the new line added to the selection, it is reading the entire selected content.
This has been tested with Eclipse 3.7.2 classic and J2EE and Eclipse 3.6 to see if this was an issue introduced in the 3.7 series.
Blocking #4480, #4534
The text was updated successfully, but these errors were encountered: