Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-on Information dialog: URL displayed as Python "None" if URL not present in manifest #2322

Closed
nvaccessAuto opened this issue May 11, 2012 · 2 comments
Closed

Add-on Information dialog: URL displayed as Python "None" if URL not present in manifest #2322

nvaccessAuto opened this issue May 11, 2012 · 2 comments
Labels
bug component/NVDA-GUI
Milestone
2012.2

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2012-05-11 00:06
The URL is an optional field. We don't fail if it's not specified, but we don't check for it, so we display Python "None". Aside from being ugly, this is untranslated. We should probably just not display the URL line in this case.
@nvaccessAuto
Copy link
Author

Comment 1 by ragb (in reply to comment description) on 2012-05-11 14:52
Replying to jteh:

The URL is an optional field. We don't fail if it's not specified, but we don't check for it, so we display Python "None". Aside from being ugly, this is untranslated. We should probably just not display the URL line in this case.

I think not displaying would be the best option: having sometime like "url: " is strange.

I can take care of it if you want.

@nvaccessAuto
Copy link
Author

Comment 2 by mdcurran on 2012-05-15 04:16
Fixed in 88d7dc6
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2012.2 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component/NVDA-GUI
Projects
None yet
Milestone
2012.2
Development

No branches or pull requests
1 participant
@nvaccessAuto