Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected table boundary condition on news.ycombinator while using Firefox #2362

Closed
nvaccessAuto opened this issue May 20, 2012 · 6 comments

Comments

@nvaccessAuto
Copy link

Reported by Q on 2012-05-20 06:19
While navigating the table on http://news.ycombinator.com with table navigation commands, I am only able to traverse two rows at a time before NVDA announces "edge of table."
This is using Snapshot Main 5193.

I appreciate your time.

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2014-09-12 04:32
This is due to the fact that row 3 is completely empty; i.e. it doesn't contain any cells at all:

<tr style="height:5px"></tr>

Therefore, when we go looking for a cell in row 3, we fail. I'd argue this is bad authoring, but that's the world we live in. :)

The obvious fix is to try further rows, but this could be pretty inefficient.

@nvaccessAuto
Copy link
Author

Comment 2 by Q on 2014-09-12 05:20
I'd prefer it take a long time to it not working at all, but if that won't work, are there any other alternatives?
Can we get an explicit count of rows and columns in each row, use that to detect if we're at the end so that's not slow, and otherwise go searching?

@nvaccessAuto
Copy link
Author

Comment 3 by jteh (in reply to comment 2) on 2014-09-12 05:44
Replying to Q:

I'd prefer it take a long time to it not working at all

My concern isn't that this specific case might take a long time, but that the change might cause tables overall to slow down. In other words, I'm happy for poor authoring to suffer, but I don't want everything else to suffer to compensate for poor authoring.

I'll see what I can come up with when I get some time. If you/someone else wants to poke at this, I can provide a quick brain dump on where to start.

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2014-09-12 05:45
Assigning to me for now so this doesn't get lost forever again.

@bhavyashah
Copy link

@jcsteh notes in #2362 (comment) - "I'll see what I can come up with when I get some time. If you/someone else wants to poke at this, I can provide a quick brain dump on where to start." Could you please do one of the above and share your thoughts?

@jcsteh
Copy link
Contributor

jcsteh commented Aug 14, 2017

Fixed by #7410. CC @ctoth.

@jcsteh jcsteh closed this as completed Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants