Comment 1 by jteh on 2012-07-26 23:09
Cleaning up on cancel is pretty controversial. Particularly when updating a portable copy, this doesn't make sense, though the portable copy will be broken regardless.

Comment 2 by elliott94 (in reply to comment 1) on 2012-07-26 23:15
Replying to jteh:

Cleaning up on cancel is pretty controversial. Particularly when updating a portable copy, this doesn't make sense, though the portable copy will be broken regardless.

You make a good point; what's more, users may have custom configuration (add-ons, etc) that they obviously wouldn't want to be unnecessarily removed without confirmation first.

Comment 3 by briang1 on 2012-07-27 08:36
It all depends on how complex you want to make creating the portable copy and how long you want it to take.
The ultimate way is to do as you do with the installed version, ie force it to go to a known location. Then ask where you want it afterwards. Assuming you have chosen a folder with other files in it, then questions need to be asked.
All of these things take time and make portable creation take a long time.
Maybe the only check really needed is for nvda to say, the chosen folder is not empty and allow the user to view the contents and continue or abort.

From the comment in #2565 (comment), this sounds sort of related to #3113