Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

papenmeier: fix indentation to correctly validate read packets #3174

Closed
nvaccessAuto opened this issue Apr 20, 2013 · 4 comments
Closed

papenmeier: fix indentation to correctly validate read packets #3174

nvaccessAuto opened this issue Apr 20, 2013 · 4 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by halim on 2013-04-20 06:43
Sorry for that.
The attached patch fixes an indentation problem.
It's save to add it to master and 2013-1.

@nvaccessAuto
Copy link
Author

Attachment papenmeier.patch added by halim on 2013-04-20 06:48
Description:
patch

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2013-04-21 01:13
Please describe the issue this fixes from a user perspective; e.g. fixes inability to connect to the display in some cases. Also, was this bug present in 2012.3 or was it introduced recently?
Changes:
Milestone changed from None to 2013.1

@nvaccessAuto
Copy link
Author

Comment 3 by halim on 2013-04-21 07:47
This issue could cause error when reading keys from the braille display or when detecting different models of papenmeier devices.
A received packet from the display contains a STX at the begining and ends with a ETX.
Currently the display could send a bad packet which doesn't start with a stx but correctly ends with ETX would cause errors when parsing it.
The issue is a simple indentation bug which is present in 2013-1 rc1 and git master.
Thx.

@nvaccessAuto
Copy link
Author

Comment 4 by James Teh <jamie@... on 2013-04-22 08:43
In [048cef8]:

Fix a problem which sometimes occurred when connecting to or pressing keys on Papenmeier BRAILLEX newer models.

This was caused by an indentation error.
Fixes #3174.

Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants