Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear espeak-data directory when installing #3181

Closed
nvaccessAuto opened this issue Apr 22, 2013 · 6 comments
Closed

Clear espeak-data directory when installing #3181

nvaccessAuto opened this issue Apr 22, 2013 · 6 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2013-04-22 06:04
Jonathan pointed out that we need to clear out the espeak-data directory when installing. Otherwise, multiple copies of voices and other files can be left around when they've been moved in eSpeak. In particular, the recent reorganisation of espeak-data\voices means that there are a lot of duplicates.

@nvaccessAuto
Copy link
Author

Comment 1 by briang1 on 2013-04-22 06:46
Would this not delete users tweaked voices though, and thus cause issues of the voice no longer existing which is currently selected as default?

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2013-04-22 07:36
It would remove the voices, but we've never guaranteed they'd be left alone. With the most recent code, a missing default voice shouldn't break things. I don't see any other way to get around this.

@nvaccessAuto
Copy link
Author

Comment 3 by briang1 on 2013-04-22 09:03
Maybe y users need to remove their voices and put them back afterwards. Not sure how you would accomplish this in time though.
Would lready tweaked voices be usable in the new system?

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2013-04-24 07:28
Jonathan, is it enough to just remove everything in espeak-data\voices (excluding !v)?

@nvaccessAuto
Copy link
Author

Comment 5 by jonsd on 2013-04-24 09:20
Ideally you should remove the entire espeak-data directory (unless you want to keep the contents of voices!v).

It's possible that someone has added *_dict files for experimental languages which are not replaced by the new NVDA installation, and may be incompatible with the new version of eSpeak. However, I think this is an unlikely situation and in any case such a user would probably understand the situation.

So yes, it should be enough to just remove everything in espeak-data\voices (excluding !v).

@nvaccessAuto
Copy link
Author

Comment 6 by James Teh <jamie@... on 2013-04-25 23:49
In [2787cf6]:

When updating a previous installation, old eSpeak voices are now removed.

Before copying in the new files, everything in the espeak-data\voices directory is removed except for variants.
Otherwise, multiple copies of voices and other files can be left around when they've been moved in eSpeak. In particular, the recent reorganisation of espeak-data\voices means that there are a lot of duplicates.
Fixes #3181.

Changes:
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants