Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA allows to open its dialogs when an wx file or dir dialog is opened #3361

Open
nvaccessAuto opened this issue Jul 12, 2013 · 8 comments
Open

Comments

@nvaccessAuto
Copy link

Reported by norrumar on 2013-07-12 06:03
When a file or dir dialog is opened, it's not possible to use tab keys on NVDA settings dialogs.
Furthermore, when opening General settings on some dialogs, for example Save as on Log viewer, an error is produced.
So NVDA shouldn't allow to open settings dialogs if an wx file or dir dialog is already opened.
I think it could be done as in message box dialog, for instance creating a function for these kind of dialogs, or just a variable to report that one of them is opened.

@nvaccessAuto
Copy link
Author

Attachment nvda.log added by norrumar on 2013-07-12 06:08
Description:
Examples of file to open and save, and dir to save or restore dialogs.

@nvaccessAuto
Copy link
Author

Attachment 0001-Added-gui.isInSelectorDialog.-Set-True-on-addonGui-o.patch added by norrumar on 2013-07-14 16:20
Description:
Suggestion to fix this bug

@nvaccessAuto
Copy link
Author

Comment 1 by norrumar on 2013-07-14 16:26

  • It's added the variable isInSelectorDialog on gui.init.py, under isInMessageBox.
  • Functions to select files set True or False this variable when creating and destroing the corresponding dialogs:
  • Function for selecting an addon to install.
  • To choose the folder where a portable copy could be created.
  • To choose a file to save the log.
    I don't know if there are more commands like these.

@nvaccessAuto
Copy link
Author

Comment 2 by nvdakor on 2015-03-02 15:06
Hi,
Confirmed - this bug still exists with WXPython 3.0.2.0, a side effect of the problem discussed on a ticket about folder and file names announced twice while browsing for add-ons.
Thanks.

@bhavyashah
Copy link

I am wondering if this bug still persists with WxPython 4.0, the version NVDA is going to eventually shift to. This might be a ticket worth addressing at a point in time when Python 3/WxPython 4 transition becomes a area being actively worked upon in NVDA. CC @josephsl

@Adriani90
Copy link
Collaborator

This is partly reproducible in NVDA 2019.1.1 on WX 4.0.4as following:

  1. Open the log viewer of NVDA
  2. Open the save as dialog
  3. press ctrl+nvda+s or the shortcut for any other NVDA settings dialog apart from the general settings
  4. Press tab or shift+tab

Actual: NVDA is not reporting anything is the focus is not moving.
Expected: NVDA should not open the dialog. A dialog should be displayed where the user is requested to close the open dialogs.

@Adriani90
Copy link
Collaborator

The general settings dialog is not visibly displayed, however it seems it is fired without any warnings. Pressing ctrl+nvda+g twice displays a dialog which says that a settings dialog is already opened although this is not visible on the screen.

@Adriani90
Copy link
Collaborator

Still reproducible in NVDA last alpha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants