Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigatorObject_toFocus doesn't send a becomeNavigatorObject event #3464

Open
nvaccessAuto opened this issue Aug 24, 2013 · 3 comments
Open

navigatorObject_toFocus doesn't send a becomeNavigatorObject event #3464

nvaccessAuto opened this issue Aug 24, 2013 · 3 comments
Labels
bug good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority z goodForNewDev (archived)

Comments

@nvaccessAuto
Copy link

Reported by dpeschel on 2013-08-24 00:54
These methods all send becomeNavigatorObject events:
navigatorObject_parent
navigatorObject_previous
navigatorObject_next
navigatorObject_firstChild

but navigatorObject_toFocus doesn't. This seems odd if you consider navigatorObject_toFocus as equivalent to some sequence of the other four actions.

(Tested using Takuya Nishimoto's FocusHighlight add-in. I removed the timer-driven redraws to see if I could speed up response time. The timer-driven redraws hide this behavior; removing them reveals it.)
@LeonarddeR
Copy link
Collaborator

LeonarddeR commented Jul 7, 2017 •
edited by derekriemer

Confirmed. @jcsteh: Do you agree with a p4 here? It is probably quite easy to fix, but not very important. In the case of focus highlight, you are moving the navigator object to focus, so you already have the highlight around the focus.

@jcsteh jcsteh added z goodForNewDev (archived) p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority labels Jul 10, 2017
@jcsteh
Copy link
Contributor

jcsteh commented Jul 10, 2017

Labelled p4 and also goodForNewDev.

@Adriani90
Copy link
Collaborator

@LeonarddeR this might be of interest when implementing the focus and carret highlighting PR.

@seanbudd seanbudd added the good first issue github features these at https://github.com/nvaccess/nvda/contribute label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue github features these at https://github.com/nvaccess/nvda/contribute p5 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority z goodForNewDev (archived)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@LeonarddeR @jcsteh @seanbudd @nvaccessAuto @Adriani90