New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out downloader used by updateCheck so it can be used elsewhere #3504
Comments
@jcsteh / @feerrenrut: Mind setting a milestone/priority for this? |
This work would be to generify the current implementation so that it could easily be used to display an active nvda "background task". Please correct me if I have misunderstood. P3 Assuming that I have understood this issue correctly. |
One idea: When the user presses donate, they have to go donate, and come back to On 11/11/2016 10:54 PM, Reef Turner wrote:
Websites: email me at derek.riemer@colorado.edu mailto:derek.riemer@colorado.edu |
I actually wrote a branch (t3504) years ago which does most (maybe all?) of this. I can't remember why I abandoned it. I think perhaps it wasn't going to fully solve the use case I had at the time (the OCR add-on) and I didn't see any point in pursuing it further. Unfortunately, I don't remember if anything was incomplete, but a brief look suggests not. It'll probably be partial bit rot by now, though. |
Hi, The download manager should be able to download URL's it receives (not only NVDA updates, but also add-on updates as well). We should limit this to installed copies only (after all, the file in question will be stored in temp directory). In case of add-ons manager using this, see #3208. Thanks. |
One interesting thing I have noticed is that nvedas downloader is slower
than the one in Firefox for the same files if you manually download them.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Sent: Saturday, November 26, 2016 6:04 AM
Subject: Re: [nvaccess/nvda] Split out downloader used by updateCheck so it
can be used elsewhere (#3504)
… Hi,
The download manager should be able to download URL's it receives (not
only NVDA updates, but also add-on updates as well). We should limit this
to installed copies only (after all, the file in question will be stored
in temp directory). In case of add-ons manager using this, see #3208.
Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#3504 (comment)
|
…recent releases. re nvaccess#3504 Modernized Jamie Teh's downloader class to include file hashes and other changes from recent releases. Testing shows it is working as advertised.
…recent releases. re nvaccess#3504 Modernized Jamie Teh's downloader class to include file hashes and other changes from recent releases. Testing shows it is working as advertised.
Hi, Modernized to include enhancements from recent releases, including HTTPS support, file hashes and so on. Testing shows it is working as advertised by @jcsteh. Thanks. |
@josephsl will this be also solved when the addon update feature come into NVDA's core? Or are you going to raise a separate PR for this? |
Hi, I’d say it would be best to ask @jcsteh if he wants to deal with this, as he is the originator of a supposed branch for this. Thanks.
From: Adriani90 <notifications@github.com>
Sent: Monday, December 10, 2018 4:20 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Split out downloader used by updateCheck so it can be used elsewhere (#3504)
@josephsl <https://github.com/josephsl> will this be also solved when the addon update feature come into NVDA's core? Or are you going to raise a separate PR for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#3504 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgLkAdXzZlSl5ByIUPfvukNZ0UtxBO7ks5u3lFmgaJpZM4Kv_Ih> .
|
I believe that it would allow updating addons via addonUpdater on try builds, which would be very nice to have. @josephsl Am i right? If I am maybe you can consider working on this. |
Hi, No, because Ad-on Updater is really an implementation of #3208, not this one. I also prefer to limit this to Core modules as we don't want someone writing an add-on designed to promote download of illegal content through NVDA. Thanks. |
Reported by jteh on 2013-09-06 04:57
updateCheck.UpdateDownloader downloads updates and displays an appropriate GUI, including progress indication. This requires quite a bit of code because, among other reasons, the download needs to happen in a background thread so it doesn't block NVDA. It'd be nice if this could be used by other code in future.
The text was updated successfully, but these errors were encountered: