Central Window to Dispatch windows messages #3570

nvaccessAuto · 2013-10-10T09:42:16Z

Reported by ragb on 2013-10-10 09:42
As discussed on #1271 we need to process WM_DEVICECHANGE messages, so a rgistered window is needed. One is already created in the Freedom scientific driver and, per haps, elsewhere. So I purpose the creation of a central window where windows message handlers can be registered by various modules to be notified of WM_* messages. Don't know if one can reuse the NVDA WX window for this or not.

A starting point might be this:

http://wiki.wxpython.org/MonitoringWindowsUsb

Although the code is somehow specific to windows monitoring, the generalized handling is there.

I'm not sure if we must block #1271 or not, because #1271 implementation will be far more elegant with this.

nvaccessAuto · 2013-10-14T08:09:36Z

Comment 1 by jteh on 2013-10-14 08:09
After discussing this with Mick, we feel it definitely makes sense to abstract the handling of such windows. However, having one single core window is probably not the right course for now:

If more than one handler wants to handle the same message, it's unclear what should be done. Window messages can return values, so it's not as simple as just calling multiple handlers for that message.
There's nothing in the core (except for drivers) that currently needs to handle window messages in the main thread. touchHandler does, but it has to do this in a background thread. It's probably not unreasonable for plugins and drivers to have their own message windows.

That said, it obviously makes sense to eliminate duplicate code. So, we should have a class which handles most of the work (creation, destruction, etc.) and which can be easily subclassed to handle particular messages.

nvaccessAuto · 2015-01-09T02:45:06Z

Comment 4 by James Teh <jamie@... on 2015-01-09 02:45
In [2096318]:

Add windowUtils.CustomWindow, a base class to enable simple implementation of custom windows.

This allows for the creation of a window with a provided class name and windowProc implementation.
Re #3570.

…ation of custom windows. This allows for the creation of a window with a provided class name and windowProc implementation. Re #3570.

bhavyashah · 2017-08-16T11:06:04Z

@jcsteh's #3570 (comment) and #3570 (reference) seems to indicate that there has been work done on this. Could we please be updated about the present status of this work?

jcsteh · 2017-08-16T11:41:38Z

2096318 implements windowUtils.CustomWindow, which satisfies the narrowed requirements outlined in #3570 (comment).

Note that a4a4700 does actually implement a core custom window, though you can't register to receive arbitrary messages. However, given the concerns outlined in #3570 (comment), I still don't think going this far is a good idea anyway.

Regarding the original purpose of receiving device change messages (as outlined in #3570 (comment)), we could add some very simple logic into the core CustomWindow to catch WM_DEVICECHANGE and have this use an Action extension point (as provided by #7484) to notify interested components about device changes.

In short, I think we're done with this issue. Closing.

commit 2c0612a Merge: f202d70 e71a06a Author: Leonard de Ruijter <leonard@babbage.com> Date: Fri Sep 1 06:58:18 2017 +0200 Merge remote-tracking branch 'origin/master' into t1271a2 commit f202d70 Author: James Teh <jamie@nvaccess.org> Date: Fri Jan 17 06:46:00 2014 +0000 alvaBC6: Raise an exception when sending braille fails so NVDA knows about it. commit 292302c Author: James Teh <jamie@nvaccess.org> Date: Fri Jan 17 05:57:56 2014 +0000 alvaBC6 driver: Update for bdDetect. commit a2e5633 Author: James Teh <jamie@nvaccess.org> Date: Fri Jan 17 05:56:55 2014 +0000 braille: If the port is unspecified, try automatic. commit 8a7c3ad Author: James Teh <jamie@nvaccess.org> Date: Thu Jan 16 07:19:05 2014 +0000 brailleNote driver: Update for bdDetect. commit a64c519 Author: James Teh <jamie@nvaccess.org> Date: Thu Jan 16 07:08:56 2014 +0000 baum: Fix and simplification. commit 7ed9945 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 14:09:57 2013 +1000 brailliantB driver: Update for new auto port handling. commit ab394f7 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 14:09:28 2013 +1000 baum: Fix typo. commit d216984 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 14:04:27 2013 +1000 baum, freedomScientific drivers: Update for new auto port handling. commit b07d51e Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 13:43:25 2013 +1000 braille: Provide base support for automatic, USB and Bluetooth ports using bdDetect. Simplify support for serial ports. Rather than implementing etPossiblePorts directly, drivers should now provide bdDetect data and implement getManualPorts as appropriate. The base implementation of getPossiblePorts adds the automatic, USB and Bluetooth ports as appropriate. braille.getSerialPorts can be used in BrailleDisplayDriver.getManualPorts for displays which support serial ports. commit 21c3214 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 10:58:01 2013 +1000 bdDetect: Code doc. commit 9e9d1a4 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 10:56:06 2013 +1000 baum: Oops. Don't exclude if there are serial ports but no USB/Bluetooth ports. Simplify getPossiblePorts. commit 2494d9c Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 10:28:45 2013 +1000 alvaBC6 driver: Support auto-detection. The ALVA library still scans for devices itself at this stage, so it's slower than it could be. It should be possible to improve this in future. commit 6b7b602 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 09:53:38 2013 +1000 baum, freedomScientific drivers: Exclude from list if there are no possible devices detected. commit b80fe10 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 09:50:29 2013 +1000 brailliantB driver: Update for bdDetect. commit ed15e14 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 09:44:32 2013 +1000 bdDetect: Add arePossibleDevicesForDriver to check whether there are possible devices for a given driver. commit f233f87 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 08:59:10 2013 +1000 Update freedomScientific driver to support auto detection and use bdDetect data. commit 9863643 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 08:24:11 2013 +1000 baum driver: Complete work to support USB detection and use bdDetect data. commit 78ffd89 Author: James Teh <jamie@nvaccess.org> Date: Tue Dec 24 08:09:36 2013 +1000 bdDetect: Fix getConnectedUsbDevicesForDriver. commit 7f1021f Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 18:38:43 2013 +1000 BrailleSettingsDialog: When automatic detection is configured, show this as the active choice. Show the name of the current display in brackets if it isn't noBraille. commit 6bb6602 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 18:37:57 2013 +1000 Ug. Fix typo. commit f81fe1b Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 18:29:50 2013 +1000 bdDetect: Add functions to get possible devices detected for a specific driver. commit c40773b Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 18:20:51 2013 +1000 bdDetect: Oops. Fix getDriversForPossibleBluetoothComPorts so that it actually works. commit 24237f0 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 17:36:38 2013 +1000 Remove unneeded line. commit 07ba0b7 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 17:34:54 2013 +1000 Auto-detect and use Baum displays when connected via Bluetooth. Work is still needed on the Baum driver so USB detection works and so it uses bdDetect entirely instead of its own data, but this at least allows me to do initial testing. commit cd811bd Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 16:02:07 2013 +1000 braille: When a display is automatically detected, display the current focus/review position. commit 854ce53 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 15:51:46 2013 +1000 Automatically detect braille displays! To use this, you select "Automatic" in the list of braille displays. commit 34d2efc Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 13:45:12 2013 +1000 If NVDA is unable to communicate with a braille display (e.g. because it has been disconnected), it will automatically disable use of the display. This eliminates problems such as excessive log file size and lag when this occurs. commit 930f3e8 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 13:15:27 2013 +1000 bdDetect: Scan for new USB devices and Bluetooth com ports when Windows notifies that a device has been added/removed. commit c56a401 Merge: 4a707f0 c072496 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 10:40:47 2013 +1000 Merge branch 't3570' into t1271a2 commit 4a707f0 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 23 10:36:01 2013 +1000 Initial code for bdDetect module for braille display detection. Allows drivers to register USB device IDs and Bluetooth names/addresses for Bluetooth com ports. The module can then provide information about what drivers should be loaded based on available devices. It can also automatically detect available devices. Handling of added USB devices/Bluetooth com ports will be added in future commits. commit a53b153 Author: James Teh <jamie@nvaccess.org> Date: Fri Dec 13 16:58:03 2013 +1000 Add hwPortUtils.listUsbDevices to list IDs of USB devices on the system. commit c072496 Author: James Teh <jamie@nvaccess.org> Date: Mon Dec 9 12:31:26 2013 +1000 Add windowUtils.CustomWindow, a base class to enable simple implementation of custom windows. This allows for the creation of a window with a provided class name and windowProc implementation. Re nvaccess#3570.

nvaccessAuto added the enhancement label Nov 10, 2015

jcsteh added a commit that referenced this issue Nov 23, 2015

Add windowUtils.CustomWindow, a base class to enable simple implement…

2096318

…ation of custom windows. This allows for the creation of a window with a provided class name and windowProc implementation. Re #3570.

jcsteh closed this as completed Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Central Window to Dispatch windows messages #3570

Central Window to Dispatch windows messages #3570

nvaccessAuto commented Oct 10, 2013

nvaccessAuto commented Oct 14, 2013

nvaccessAuto commented Jan 9, 2015

bhavyashah commented Aug 16, 2017

jcsteh commented Aug 16, 2017

Central Window to Dispatch windows messages #3570

Central Window to Dispatch windows messages #3570

Comments

nvaccessAuto commented Oct 10, 2013

nvaccessAuto commented Oct 14, 2013

nvaccessAuto commented Jan 9, 2015

bhavyashah commented Aug 16, 2017

jcsteh commented Aug 16, 2017