Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ASLR when building dlls #3609

Closed
nvaccessAuto opened this issue Oct 28, 2013 · 6 comments
Closed

Enable ASLR when building dlls #3609

nvaccessAuto opened this issue Oct 28, 2013 · 6 comments
Labels
feature security

Comments

@nvaccessAuto
Copy link

Reported by tspivey on 2013-10-28 02:59
Since NVDA injects code into other processes, I think ASLR should be enabled for its dlls. Linking with /dynamicbase should do it. Pre-vista systems should ignore this flag; I haven't yet tried this to see what side effects this might have.
@LeonarddeR
Copy link
Collaborator

CC @tspivey @jcsteh

@Adriani90
Copy link
Collaborator

cc: @michaelDCurran, @feerrenrut, @dglee42 your thoughts are very appreciated in this regard.

@michaelDCurran
Copy link
Member

@tspivey for completeness, could you please outline why this is necessary?

@Adriani90
Copy link
Collaborator

@tspivey could you please reply to the comment above? Thanks.

@tspivey
Copy link
Collaborator

tspivey commented Jan 2, 2019

IIRC, it's used so any exploits can't target one specific memory address with known values.

However, if I'm reading this right, according to process explorer, nvdaHelperRemote.dll and minHook.dll already have it on.

@LeonarddeR
Copy link
Collaborator

As per above, I"m closing this as works for me. If this issue requires a revisit, let us now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@tspivey @LeonarddeR @derekriemer @michaelDCurran @nvaccessAuto @Adriani90