Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input gestures dialog does not show the windows key used in a shortcut #3628

Closed
nvaccessAuto opened this issue Nov 7, 2013 · 2 comments
Closed

input gestures dialog does not show the windows key used in a shortcut #3628

nvaccessAuto opened this issue Nov 7, 2013 · 2 comments
Assignees
@jcsteh
Labels
bug
Milestone
2013.3

Comments

@nvaccessAuto
Copy link

Reported by surveyor on 2013-11-07 14:41
To reproduce, open input gestures dialog, select one action and press add button.
press for instance nvda+windows+a.

Actual: NVDA shows the new gesture as NVDA+a.

Expected: it should be displayed with windows key.
Even if the dialog does not display, shortcuts with windows key are saved in gestures.ini file as expected.
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2013-11-08 01:48
Changes:
Milestone changed from None to 2013.3

@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2013-11-08 02:06
In [71e5ea8]:

In the Input Gestures dialog, the Windows key is correctly displayed when it is included in a gesture.

KeyboardInputGesture.getDisplayNameTextForIdentifier wasn't handling NVDA's fake vk codes when checking for modifiers and VK_WIN is fake.
Fixes #3628.

Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2013.3 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug
Projects
None yet
Milestone
2013.3
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto