Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sayAll should only update controlField/formatfield speech caches when the caret is updated #3688

Closed
nvaccessAuto opened this issue Dec 3, 2013 · 3 comments

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2013-12-03 04:21
Currently speech.speakTextInfo updates its speech caches on the TextInfo's obj when it is called, even inside a current sayAll. This causes an issue where if sayAll is reading down a document and enters a field such as a table, the speech cache is updated for this situation, even though NVDA may not have actually spoken that text yet. Therefore if you then interrupt sayAll by read current line, or something, NVDA will announce something like "out of table" even though it had never actually got up to speaking entering of the table.
Saving of pseech caching to the TextInfo's obj must be delaied until an index is received from the synth for that particular text. We may wish to abstract this with some kind of speakTextInfoState object which can be passed into speakTextInfo and mutated.
Blocking #3675

@nvaccessAuto
Copy link
Author

Comment 2 by Michael Curran <mick@... on 2013-12-05 21:40
In [137e0a2]:

Merge branch 't3688' into next. Incubates #3688

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 3 by Michael Curran <mick@... on 2013-12-18 23:49
Fixed in bd799f4
Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 4 by mdcurran on 2013-12-18 23:59
Changes:
Milestone changed from next to 2014.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant