Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scons: Use Python zipfile to build zip archives #3725

Closed
nvaccessAuto opened this issue Dec 17, 2013 · 4 comments
Closed

scons: Use Python zipfile to build zip archives #3725

nvaccessAuto opened this issue Dec 17, 2013 · 4 comments
Assignees
@jcsteh
Labels
enhancement
Milestone
2014.1

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2013-12-17 22:46
We currently use 7-Zip to build the symbols and client archives, which means we depend on 7-Zip. 7-Zip isn't included in the miscDeps submodule. Python includes zip file support, so we may as well use it and kill this dependency. The archives it generates are probably slightly larger, but I think we can live with this.
@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2013-12-20 00:19
In [eb860e9]:

sconstruct: Use Python's zipfile module to generate the symbols and controller client archives instead of using 7-Zip.

This means we no longer depend on 7-Zip. The resulting archives are a bit larger, but this isn't a major issue and it's worth it to eliminate a dependency.
Re #3725.

@nvaccessAuto
Copy link
Author

Comment 3 by James Teh <jamie@... on 2013-12-20 00:19
In [2917ec6]:

Merge branch 't3725' into next

Incubates #3725.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 4 by James Teh <jamie@... on 2014-01-12 23:43
In [38add5c]:

sconstruct: Use Python's zipfile module to generate the symbols and controller client archives instead of using 7-Zip.

This means we no longer depend on 7-Zip. The resulting archives are a bit larger, but this isn't a major issue and it's worth it to eliminate a dependency.
Fixes #3725.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 5 by jteh on 2014-01-12 23:48
Changes:
Milestone changed from next to 2014.1

@nvaccessAuto nvaccessAuto added this to the 2014.1 milestone Nov 10, 2015
@feerrenrut feerrenrut mentioned this issue Aug 22, 2016
Closed
feerrenrut added a commit that referenced this issue Aug 23, 2016
@feerrenrut
Fix for issue #6206
952f257 
Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow
keypresses (including enter). This is resolved by registering an event
handler and forwarding enter presses to the dialog, and allowing thew
ListCtrl to handle all others.
@feerrenrut feerrenrut mentioned this issue Aug 23, 2016
Merged
feerrenrut added a commit that referenced this issue Sep 14, 2016
@feerrenrut
Pressing enter in the dictionary dialog results in save and exit (#6296)
0cce9f6 
Fixes #6206 

Due to a bug in wx (see wx ticket #3725) ListCtrl objects swallow
keypresses (including enter). This is resolved by registering an event
handler and forwarding enter presses to the dialog, and allowing thew
ListCtrl to handle all others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
enhancement
Projects
None yet
Milestone
2014.1
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto