Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting of spelling errors in Microsoft Word causes significant lag #3785

Closed
nvaccessAuto opened this issue Jan 17, 2014 · 4 comments
Closed
Labels
Milestone

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2014-01-17 06:15
If moving the caret around a document in Microsoft Word with report spelling errors turned on (default), there is a noticable lag before the braille display is updated. Turning off reporting of spelling errors definitely reduces the lag.
When collecting text from MS Word, we currently check for a spelling error on every word, which would mean a great deal of calls.
Perhaps we should collect all spelling error offsets at the start and match them as we move through the text by word.

@nvaccessAuto
Copy link
Author

Comment 1 by Michael Curran <mick@... on 2014-01-17 06:24
In [df1fed5]:

Merge branch 't3785' into next. Incubates #3785

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 2 by Michael Curran <mick@... on 2014-01-31 01:56
In [d642ae7]:

Merge branch 't3785'. Fixes #3785

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2014-01-31 01:58
Changes:
Milestone changed from next to 2014.1

@nvaccessAuto
Copy link
Author

Comment 4 by Michael Curran <mick@... on 2014-02-02 10:56
In [7ac923a]:

Fix a possible buffer overrun which may have caused a crash in MS Word (picked up by MSVC RTC). Re #3785

VT_BOOL uses 16 bit values, so either VARIANT_BOOL or BOOL should be used. bool (c++) is only 8 bit which is not enough. The rest of calls with VT_BOOL were using BOOL 32 bit.

@nvaccessAuto nvaccessAuto added this to the 2014.1 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant