Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify and refactor NVDA in-process code #385

Closed
nvaccessAuto opened this issue Jan 1, 2010 · 4 comments
Closed

Unify and refactor NVDA in-process code #385

nvaccessAuto opened this issue Jan 1, 2010 · 4 comments
Assignees
@michaelDCurran
Labels
MozillaWork task
Milestone
2009.1

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2009-08-08 03:50
All of NVDA's in-process code should be unified into NVDAHelper. This will reduce duplicated code and greatly ease the process of adding new in-process code. NVDAHelper will handle the setting of system hooks and components will then register hook callbacks with NVDAHelper to be executed when the hook is fired. nvVBufLib will be merged into NVDAHelper, which means it will no longer be a separate library. This is becoming far too difficult to maintain and the advantages greatly outweigh the disadvantages.

Most of this work is already complete. However, we should be tracking these issues properly. :)
Blocking #246, #309, #375, #381, #386, #387
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2009-08-08 03:52
Bzr branch: http://bzr.nvaccess.org/nvda/nvdaHelperRewrite/
This also fixes some crashes in nvVBufLib due to better detection of when a buffer should be terminated.

@nvaccessAuto
Copy link
Author

Comment by jteh on 2009-08-08 03:58
(In #381) Bzr branches:

@nvaccessAuto
Copy link
Author

Comment by aleksey_s on 2009-08-10 16:12
(In #387) Fixed in bzr nvdaHelperRewrite r2932.
Btw, I am thinking about organizing our node-specific code somehow. May be separate code for each node into functions and put them into array or map...

@nvaccessAuto
Copy link
Author

Comment 8 by jteh on 2009-08-17 10:58
Merged in r3110.
Changes:
State: closed

@nvaccessAuto nvaccessAuto added this to the 2009.1 milestone Nov 10, 2015
This was referenced Nov 10, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelDCurran michaelDCurran

Labels
MozillaWork task
Projects
None yet
Milestone
2009.1
Development

No branches or pull requests
2 participants
@michaelDCurran @nvaccessAuto