Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gecko vbuf backend: Don't fetch stuff that isn't needed for a node #3889

Closed
nvaccessAuto opened this issue Feb 17, 2014 · 2 comments
Closed

Gecko vbuf backend: Don't fetch stuff that isn't needed for a node #3889

nvaccessAuto opened this issue Feb 17, 2014 · 2 comments
Assignees
@jcsteh
Labels
close/wontfix enhancement feature/browse-mode performance

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2014-02-17 02:54
We fetch text even when we aren't going to render children, keyboard shortcut and description even when invisible, etc. Where reasonable, this should be fixed, though there are certain cases where doing this would make the code very difficult to read, so don't bother with those.

This depends on #1354, as I started this as part of that work.
Blocked by #1354
@derekriemer
Copy link
Collaborator

@jcsteh Is this still an issue?

@jcsteh
Copy link
Contributor

jcsteh commented Jan 2, 2017

It's still valid, but I suspect the gains won't justify the effort and potential for regressions. There probably aren't that many nodes in the grand scheme of things where we don't render children or which are in the tree but considered invisible. I'm going to close this.

@jcsteh jcsteh closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
close/wontfix enhancement feature/browse-mode performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcsteh @derekriemer @nvaccessAuto