Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook 2010 signature dialog: single controls wrapped in their own MsoCommandBar causing unneeded focus ancestry reporting #4096

Closed
nvaccessAuto opened this issue Apr 28, 2014 · 10 comments
Labels
Milestone

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2014-04-28 04:29
In the Signature dialog in Outlook 2010, many of the font controls (which are individually tabbable) are each wrapped in their own MsoCommandBar Toolbar. This leads to major overspeaking when tabbing around. These SomCommandBar toolbars in Outlook should be silenced in focus ancestry if they have one child.
Blocking #3407

@nvaccessAuto
Copy link
Author

Comment 2 by nvdakor on 2014-04-28 04:33
Hi Mick,
Is this the same problem as #3407?

@nvaccessAuto
Copy link
Author

Comment 3 by Michael Curran <mick@... on 2014-04-28 04:34
In [bcc9ed5]:

Merge branch 't4096' into next. Incubates #4096

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 4 by nvdakor on 2014-04-28 04:50
Hi Mick,
When I open manage rules dialog which has a similar problem, I get the following traceback:

ERROR - eventHandler.executeEvent (21:42:54):
error executing event: focusEntered on <appModules.outlook.MsoCommandBarToolBar object at 0x04C98CD0> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.py", line 143, in executeEvent
    _EventExecuter(eventName,obj,kwargs)
  File "eventHandler.py", line 91, in __init__
    self.next()
  File "eventHandler.py", line 98, in next
    return func(*args, **self.kwargs)
  File "NVDAObjects\__init__.py", line 838, in event_focusEntered
    if self.isPresentableFocusAncestor:
  File "baseObject.py", line 34, in __get__
    return instance._getPropertyViaCache(self.fget)
  File "baseObject.py", line 110, in _getPropertyViaCache
    val=getterMethod(self)
  File "appModules\outlook.py", line 242, in _get_isPresentableFocusAncestor
    return super(MsoCommandBar,self).isPresentableFocusAncestor
NameError: global name 'MsoCommandBar' is not defined

Thanks.

@nvaccessAuto
Copy link
Author

Comment 5 by Michael Curran <mick@... on 2014-04-28 05:18
In [c4015ab]:

Merge branch 't4096' into next. Incubates #4096

@nvaccessAuto
Copy link
Author

Comment 6 by mdcurran (in reply to comment 4) on 2014-04-28 05:24
Replying to nvdakor
Should be fixed in the last commit. Just a typo. However, if you are seeing that, then most likely this code won't help that particular situation.

@nvaccessAuto
Copy link
Author

Comment 7 by nvdakor (in reply to comment 6) on 2014-04-28 05:29
Replying to mdcurran:

Replying to nvdakor

Should be fixed in the last commit. Just a typo. However, if you are seeing that, then most likely this code won't help that particular situation.

Yes, typo's gone. The code for 4096 does not solve manage rules dialog problem (#3407). Thanks.

@nvaccessAuto
Copy link
Author

Comment 9 by nvdakor on 2014-04-28 23:03
Hi Mick,
It turns out this isn't limited to Outlook: Envelopes dialog in Microsoft Word 2010 has the exact problem (see ticket #3053).
Thanks.

@nvaccessAuto
Copy link
Author

Comment 10 by Michael Curran <mick@... on 2014-06-10 04:33
In [536ad31]:

Merge branch 't4096'. Fixes #4096

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 11 by mdcurran on 2014-06-10 04:35
Changes:
Milestone changed from next to 2014.3

@nvaccessAuto nvaccessAuto added this to the 2014.3 milestone Nov 10, 2015
@Adriani90
Copy link
Collaborator

Testing on Windows 10 with NVDA 2018.4 Beta 2 and MS Word 2016 and MS Outlook 2016:
I.e. for the envelope dialog in MS word, when tabbing around I get following error:

IO - inputCore.InputManager.executeGesture (23:05:39.802):
Input: kb(laptop):shift+tab
DEBUGWARNING - NVDAObjects.window.winword.WordDocument._get_WinwordWindowObject (23:05:39.839):
Could not get MS Word object model from window 330256 with class _WwN
Traceback (most recent call last):
  File "NVDAObjects\window\winword.pyo", line 1173, in _get_WinwordWindowObject
  File "oleacc.pyo", line 237, in AccessibleObjectFromWindow
  File "_ctypes/callproc.c", line 950, in GetResult
WindowsError: [Error -2147467259] Unbekannter Fehler
ERROR - scriptHandler.executeScript (23:05:39.845):
error executing script: <bound method Dynamic_WordDocumentEditableTextWithoutAutoSelectDetectionUIAWindowNVDAObject.script_tab of <baseObject.Dynamic_WordDocumentEditableTextWithoutAutoSelectDetectionUIAWindowNVDAObject object at 0x06843190>> with gesture u'Umschalt+Tab'
Traceback (most recent call last):
  File "scriptHandler.pyo", line 187, in executeScript
  File "NVDAObjects\window\winword.pyo", line 1351, in script_tab
  File "documentBase.pyo", line 24, in makeTextInfo
  File "NVDAObjects\UIA\__init__.pyo", line 287, in __init__
NotImplementedError: UIAutomationTextRangeArray is empty

Developer info:

Developer info for navigator object:
name: u'Etiketten'
role: ROLE_TAB
states: STATE_FOCUSED, STATE_SELECTED
isFocusable: False
hasFocus: True
Python object: <NVDAObjects.IAccessible.IAccessible object at 0x068430F0>
Python class mro: (<class 'NVDAObjects.IAccessible.IAccessible'>, <class 'NVDAObjects.window.Window'>, <class 'NVDAObjects.NVDAObject'>, <class 'documentBase.TextContainerObject'>, <class 'baseObject.ScriptableObject'>, <class 'baseObject.AutoPropertyObject'>, <type 'object'>)
description: None
location: RectLTWH(left=1070, top=188, width=152, height=55)
value: None
appModule: <'appModuleHandler' (appName u'winword', process ID 1472) at address 4876670>
appModule.productName: u'Microsoft Office'
appModule.productVersion: u'16.0.11001.20108'
TextInfo: <class 'NVDAObjects.NVDAObjectTextInfo'>
windowHandle: 330118
windowClassName: u'bosa_sdm_msword'
windowControlID: 0
windowStyle: -1798832128
windowThreadID: 13460
windowText: u'Umschl\xe4ge und Etiketten'
displayText: u'Etiketten'
IAccessibleObject: <POINTER(IAccessible) ptr=0x726fe80 at 68468a0>
IAccessibleChildID: 2
IAccessible event parameters: windowHandle=330118, objectID=17, childID=2
IAccessible accName: u'Etiketten'
IAccessible accRole: ROLE_SYSTEM_PAGETAB
IAccessible accState: STATE_SYSTEM_SELECTED, STATE_SYSTEM_FOCUSED, STATE_SYSTEM_VALID (6)
IAccessible accDescription: None
IAccessible accValue: exception: (-2147352573, 'Mitglied nicht gefunden.', (None, None, None, 0, None))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants