Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announcement of row/column headers to braille display #4195

Open
nvaccessAuto opened this issue Jun 13, 2014 · 8 comments
Open

Announcement of row/column headers to braille display #4195

nvaccessAuto opened this issue Jun 13, 2014 · 8 comments
Labels
app/microsoft-office component/braille enhancement

Comments

@nvaccessAuto
Copy link

Reported by nishimotz on 2014-06-13 10:22
Attached patch (as well as shown below) enables to include row/column headers in braille display if format information setting 'Table row/column headers' is checked.

Tested with Windows 7 and Excel 2010 (NVDA+shift+c/r).

diff --git a/source/braille.py b/source/braille.py
index 6971d81..58ec12c 100644
--- a/source/braille.py
+++ b/source/braille.py
@@ -492,15 +492,18 @@ def getBrailleTextForProperties(**propertyValues):
            # Translators: Displayed in braille when an object (e.g. a tree view item) has a hierarchical level.
            # %s is replaced with the level.
            textList.append(_('lv %s')%positionInfo[= propertyValues.get("rowHeaderText")
+   if rowHeaderText:
+       textList.append(rowHeaderText)
+   columnHeaderText = propertyValues.get("columnHeaderText")
+   if columnHeaderText:
+       textList.append(columnHeaderText)
    if rowNumber:
        if includeTableCellCoords and not cellCoordsText: 
            # Translators: Displayed in braille for a table cell row number.
            # %s is replaced with the row number.
            textList.append(_("r%s") % rowNumber)
    if columnNumber:
-       columnHeaderText = propertyValues.get("columnHeaderText")
-       if columnHeaderText:
-           textList.append(columnHeaderText)
        if includeTableCellCoords and not cellCoordsText:
            # Translators: Displayed in braille for a table cell column number.
            # %s is replaced with the column number.
@@ -536,6 +539,8 @@ class NVDAObjectRegion(Region):
            keyboardShortcut=obj.keyboardShortcut if presConfig["reportKeyboardShortcuts"]('level'])
+   rowHeaderText) else None,
            positionInfo=obj.positionInfo if presConfig[else None,
            cellCoordsText=obj.cellCoordsText if config.conf["documentFormatting"]("reportObjectPositionInformation"])[else None,
+           columnHeaderText=obj.columnHeaderText if hasattr(obj, "columnHeaderText") and config.conf["documentFormatting"]("reportTableCellCoords"])[else None,
+           rowHeaderText=obj.rowHeaderText if hasattr(obj, "rowHeaderText") and config.conf["documentFormatting"]("reportTableHeaders"])["reportTableHeaders"] else None,
        )
        self.rawText = text + self.appendText
        super(NVDAObjectRegion, self).update()
--
@nvaccessAuto
Copy link
Author

Attachment 0001-use-column-row-headers-for-braille-display.patch added by nishimotz on 2014-06-13 11:50
Description:

@nvaccessAuto
Copy link
Author

Comment 1 by nishimotz on 2014-06-13 11:53
I have replaced the attachment file to append the patch below (although I am not sure it is necessary):

@@ -580,6 +585,7 @@ def getControlFieldBraille(field, ancestors, reportStart, formatConfig):
        }
        if reportTableHeaders:
            props[= field.get("table-columnheadertext")
+           props["rowHeaderText"]("columnHeaderText"]) = fields.get("table-rowheadertext")
        return getBrailleTextForProperties(**props)

    elif reportStart:

@nvaccessAuto
Copy link
Author

Comment 2 by Michael Curran <mick@... on 2014-06-16 02:36
In [e5dc3e3]:

Merge branch 't4195' into next. Incubates #4195

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2014-08-05 01:09
Holding this back because reporting of row headers will be too verbose if they are always reported. They should only be reported if changed.

jcsteh added a commit that referenced this issue Aug 8, 2016
@jcsteh
Revert "Ensure Braille is displaying all column and row headers and c…
87ffa54 
…oordinates when configured to do so."

We've been holding this back from master for ages because reporting of row headers will be too verbose if they are always reported. Since no one is actively working on this, reverting from next until this can be looked at.
This reverts commit 9e497d5.
Reverts #4195.
@jcsteh jcsteh mentioned this issue May 26, 2017
Open
LeonarddeR pushed a commit to BabbageCom/nvda that referenced this issue May 29, 2017
@michaelDCurran
Ensure Braille is displaying all column and row headers and coordinat…
571f22f 
…es when configured to do so. Based on patch from nvaccess#4195.

Specifically:
* Display row headers, column headers, and row and column coordinates (when not overridden by cell coords text) for objects in braille.
* Display row headers for tables in documents in braille (previously only column headers were being shown).
@LeonarddeR LeonarddeR mentioned this issue May 31, 2017
Open
@Adriani90
Copy link
Collaborator

@nishimotz are you still working on this? Is there a coresponding pull request on Github? Or is the work on this Feature being continued only in this issue? In my opinion a pull request would be less confusing and better to distinguish the old patch from current commits. Thanks.

@LeonarddeR
Copy link
Collaborator

cc @dkager

@josephsl
Copy link
Collaborator

josephsl commented Jan 2, 2019

Hi,

We may need to morph this one due to issues found while incubating more than two years ago. Thanks.

@nishimotz
Copy link
Contributor

@Adriani90 I didn't create a pull request so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/microsoft-office component/braille enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@nishimotz @LeonarddeR @josephsl @michaelDCurran @nvaccessAuto @ehollig @Adriani90