Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Mozilla rich text editing hack so it works in more places #4244

Closed
nvaccessAuto opened this issue Jul 3, 2014 · 9 comments
Closed
Assignees
Labels
Milestone

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2014-07-03 04:23
We currently have a nasty hack which makes Mozilla rich text editing at least partially usable, though it's far from ideal. However, it only works when the editable area has a role of document and it isn't inside a browse mode document, which severely limits its usefulness. It isn't too hard to extend this hack to work for all editable areas. Obviously, we really want proper support for this (#1668), but this will make things a little bit better in the interim.

@nvaccessAuto
Copy link
Author

Comment 1 by James Teh <jamie@... on 2014-07-03 04:46
In [174a1fa]:

Extend our current hack to support Mozilla rich text editing to work in more places.

Previously, it only worked when the editable area had a role of document and didn't have a tree interceptor. Now, it works in any editable area that has the editable and focusable states.
Re #4244.

@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2014-07-03 04:46
In [88a12d9]:

Merge branch 't4244' into next

Incubates #4244.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 3 by ateu on 2014-07-03 11:35
Hi,

Which aps will be benefited with this change?

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2014-07-03 23:00
It is relevant to rich text editing in Mozilla based apps such as Firefox. It should help with various editors on the web, but it was primarily intended to provide partial support for the new braille mode in Google Documents (which is currently disabled for Firefox).

@nvaccessAuto
Copy link
Author

Comment 5 by nvdakor on 2014-07-06 12:44
Hi,
A Korean user who uses next snapshot reports:
In Mozilla applications such as in Firefox, when input language is set to Korean, NVDA keeps announcing "has auto-complete" each time Korean character is entered. This does not happen for English text.
STR:

  1. Start Firefox with Korean input method installed.
  2. Once the home page opens, go to address bar (Alt+D).
  3. Type a text, for example, "javascript" in both English and Korean (in Korean, with input mode set to native input via right Alt key, type wkqktmzmflvmxm).
    Expected: When typing text, NVDA doesn't say "auto-complete" each time new characters are entered. This is when typing English text.
    Actual: When typing each Korean character, NVDA announces "has auto-complete". For exampl, the user sent a log to the users group and the translation is thus:
input: w
Output: Has auto-complete, W
Input: k
Output: has auto-complete, wk
Input: q
Output: has auto-complete, wkq
...}
Specs:
* NVDA latest next snapshot.
* Firefox nightly.
The user believes that recent hack to support rich edit fields in Mozilla applications may be triggering this issue. Thanks.

@nvaccessAuto
Copy link
Author

Comment 7 by James Teh <jamie@... on 2014-07-07 10:14
In [47708f6]:

Fix continual announcement of Mozilla (and perhaps other) editable areas when typing in Korean and other east Asian languages.

Caret events are fired whenever a character is typed. However, when input composition is in progress, we fake the focus. The caret event was causing the focus to be bounced out of the input composition object back to the editable area every time a character was typed.
Fix this by ignoring these caret events when the focus is not an IAccessible.
Re #4244.

@nvaccessAuto
Copy link
Author

Comment 8 by James Teh <jamie@... on 2014-07-07 10:14
In [48c4d6a]:

Merge branch 't4244' into next

Incubates #4244.

@nvaccessAuto
Copy link
Author

Comment 9 by James Teh <jamie@... on 2014-08-05 00:44
In [09dd036]:

Slight improvements to some rich text editors in Mozilla Firefox.

This just improves our current hack and is still by no means a good solution, but it at least allows better access to some editors until we get proper support for Mozilla rich text editing.
Fixes #4244.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 10 by jteh on 2014-08-05 00:45
Changes:
Milestone changed from next to 2014.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants