Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In audacity, menus don't properly lose focus. #4289

Closed
nvaccessAuto opened this issue Jul 13, 2014 · 5 comments
Closed

In audacity, menus don't properly lose focus. #4289

nvaccessAuto opened this issue Jul 13, 2014 · 5 comments
Labels
bug close/duplicate

Comments

@nvaccessAuto
Copy link

Reported by driemer.riemer@... on 2014-07-13 22:44
I have a patch for this bug ready, I just need to make it into a patch from the master branch.

how to produce

  1. Start out by opening audacity,
  2. Record or generate some audio.
  3. open the file menu, or any other menu.
  4. press escape to close the menu. or press enter on some items.
  5. Audacity will not make the menu lose focus when it should.

In about an hour or less I should have a patch ready to post.

Blocked by #4068
@nvaccessAuto
Copy link
Author

Attachment t4289.patch added by driemer.riemer@... on 2014-07-13 23:16
Description:

@nvaccessAuto
Copy link
Author

Comment 1 by driemer.riemer@... on 2014-07-13 23:17
the patch is now attached.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2014-07-14 01:20
Thanks for the patch. Unfortunately, I don't think this is enough:

  • Escape is not the only way to close menus. This can even be done without using the keyboard, so ideally, we need a non-keyboard specific way of detecting this.
  • Are you 100% certain that the track table is always the thing that should gain focus? Are there no other views?

@nvaccessAuto
Copy link
Author

Comment 3 by david on 2014-08-06 08:37
This appears to be the same problem with Audacity as #4068. As I've just commented there, I've submitted a patch to Audacity to fix this focus problem.

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2014-08-06 09:40
Oops. This is a duplicate of #4068.
Changes:
Added labels: duplicate
State: closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug close/duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvaccessAuto