Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten top level client check in NVDAObjects.IAccessible.isPresentableFocusAncestor #4300

Closed
nvaccessAuto opened this issue Jul 17, 2014 · 1 comment · Fixed by #6247
Closed

Tighten top level client check in NVDAObjects.IAccessible.isPresentableFocusAncestor #4300

nvaccessAuto opened this issue Jul 17, 2014 · 1 comment · Fixed by #6247
Assignees
@jcsteh
Labels
bug
Milestone
2016.4

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2014-07-17 04:19
Google Chrome exposes ROLE_SYSTEM_CLIENT for some of its accessibles which don't have their own HWND. This seems odd given the name CLIENT, but MSDN is much less specific:
Microsoft Active Accessibility uses this role as a default if there is a question about the role of a UI element.

We can tighten this by using IAccessibleIdentity to check for OBJID_CLIENT, CHILDID_SELF.

This will prevent extraneous reporting of two panes when focusing Google Chrome.
@jcsteh
Copy link
Contributor

jcsteh commented Jul 1, 2016

We decided to use event_objectID/event_childID rather than IAccessibleIdentity, as root object doesn't theoretically require IAccIdentity.

@michaelDCurran michaelDCurran mentioned this issue Aug 24, 2016
Merged
@nvaccessAuto nvaccessAuto added this to the 2016.4 milestone Sep 16, 2016
jcsteh pushed a commit that referenced this issue Sep 16, 2016
@michaelDCurran @jcsteh
Initial support for the upcoming version of the Kindle app. (#6247)
41136b8 
Specifically:
* Browse mode allowing for moving through the content by character, word, line etc with the arrow keys.
* Automatic page turns when reaching the start/end of a page with the arrow keys / Say All.
* Automatic reporting of page labels or numbers if available
* Reporting of current location within a book (including percentage) via NVDA's report location command (NVDA+numpadDelete).

This includes various small changes to treeInterceptors and textInfos,handling page turns in braille, handling page turns in cursorManager and fixes for QT5.
Fixes #4300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug
Projects
None yet
Milestone
2016.4
Development

Successfully merging a pull request may close this issue.

Initial support for the upcoming version of the Kindle app nvaccess/nvda
2 participants
@jcsteh @nvaccessAuto