Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlook 2013: COMError is thrown when entering Journal folder #4305

Closed
nvaccessAuto opened this issue Jul 18, 2014 · 3 comments
Closed

Outlook 2013: COMError is thrown when entering Journal folder #4305

nvaccessAuto opened this issue Jul 18, 2014 · 3 comments
Assignees
Milestone

Comments

@nvaccessAuto
Copy link

Reported by nvdakor on 2014-07-18 08:53
Hi,
In Outlook 2013, error tones are heard when opening Journal folder and COM error is logged in the log.

STR:

  1. In Outlook 2013, open a folder other than Journal (say, Calendar or Inbox).
  2. Open Journal (Control+Y, then select Journal from the list of folders if you can see it).
    Expected: NVDA announces that we've entered Journal folder with no error tones.
    Actual: error tone is heard and the following traceback is recorded in the log:
ERROR - eventHandler.executeEvent (01:48:16):
error executing event: gainFocus on <appModules.outlook.CalendarView object at 0x045B4810> with extra args of {}
Traceback (most recent call last):
  File "eventHandler.pyc", line 143, in executeEvent
  File "eventHandler.pyc", line 91, in __init__
  File "eventHandler.pyc", line 98, in next
  File "NVDAObjects\__init__.pyc", line 862, in event_gainFocus
  File "appModules\outlook.pyc", line 343, in reportFocus
  File "comtypesMonkeyPatches.pyc", line 34, in new__getattr__
  File "comtypes\client\dynamic.pyc", line 93, in __getattr__
  File "comtypes\automation.pyc", line 643, in GetIDsOfNames
COMError: (-2147352570, 'Unknown name.', (None, None, None, 0, None))

Test setup: Windows 8.1, Outlook 2013.

Technical:
The Journal entries are shown as Calendar View object (same window class name, same control ID). Since Calendar View object assumes that we're interested in announcing time slots, it fails to take into account the fact that COM doesn't return the info we want in Journal.

Thanks.

@nvaccessAuto
Copy link
Author

Comment 1 by Joseph Lee <joseph.lee22590@... on 2014-07-18 08:58
In [14fef6b]:

Outlook/CalendarView: be sure to distinguish between an actual time slot and a journal entry, as COM erro is thrown when entering journal folder. re #4305
In report focus method for calendar view, the method assumes that the user wishes to hear time slots. This may not be the case for all objects claiming to be calendar view, such as journal entries. Thus catch this case for journal. This prevents error tones from being heard when switching to Journal in Outlook 2013 (may apply to Outlook 2010).

@nvaccessAuto
Copy link
Author

Comment 2 by Michael Curran <mick@... on 2014-08-04 23:23
In [99e78a2]:

Merge branch 't4305'. Fixes #4305

Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 3 by mdcurran on 2014-08-04 23:23
Changes:
Milestone changed from None to 2014.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants