New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in Mozilla Firefox Downloads window, NVDA repeats the information associated to the file being downloaded each time the download progress is updated #4417
Comments
Comment 1 by jteh on 2014-08-25 11:50 |
Comment 2 by blindbhavya on 2014-08-25 16:14 |
Comment 3 by blindbhavya on 2014-09-15 12:41 |
Comment 4 by blindbhavya on 2014-09-15 12:45 |
Comment 5 by blindbhavya on 2014-09-15 12:45 |
Comment 6 by jteh on 2014-09-15 21:30 It's not specifically speech related because you wouldn't fix this by modifying NVDA's speech support. You would fix it by modifying the way this event is handled for this specific case. |
Comment 7 by blindbhavya on 2014-09-16 01:26 |
Comment 8 by driemer.riemer@... on 2015-01-09 14:50 |
Comment 9 by driemer.riemer@... on 2015-01-09 15:57 Btw, would you prefer paches or linking to a git repo, or a diff? |
Attachment 0001-In-firefox-when-the-status-of-a-download-changes-nvd.patch added by driemer.riemer@... on 2015-01-09 15:59 |
Comment 11 by mdcurran on 2015-03-18 03:56 I'm having trouble following your logic. to me it looks like if the new value is the came as what is cached, then you let it through to be spoken. If it is not the same, you cache it. Shouldn't it be that you let it through to be spoken only if it is different from the cache? |
Comment 12 by driemer.riemer@... on 2015-03-18 15:50 |
Comment 13 by driemer.riemer@... on 2015-03-18 16:17 *check on ROLE_LISTITEM and STATE_SELECTED This aught to fix the issue mentioned with translatable strings. |
Attachment firefox.2.py added by driemer.riemer@... on 2015-03-18 16:18 |
Comment 14 by jteh on 2015-03-18 22:47 |
Attachment firefox.3.py added by driemer.riemer@... on 2015-03-19 01:35 |
Comment 15 by driemer.riemer@... (in reply to comment 14) on 2015-03-19 01:38
Oh. I didn't know that IA2Attributes could be checked. That is a much better way of identifying the window. I also am checking on the class of the list item now.
The newly attached file implements these changes, and also I changed the copyright date at the top from 2012 to 2015. |
Comment 16 by driemer.riemer@... on 2015-03-19 02:14 |
Attachment firefox.py added by driemer.riemer@... on 2015-03-19 02:17 |
Comment 17 by briang1 on 2015-03-19 07:50 |
Comment 18 by driemer.riemer@... on 2015-03-24 17:16 |
Comment 19 by driemer.riemer@... on 2015-05-19 19:31 |
Comment 21 by bdorer on 2015-05-29 16:54 |
Comment 22 by driemer.riemer@... on 2015-07-09 13:24 |
Comment 23 by jteh on 2015-07-09 23:28 Whether this gets into 2015.3 depends on whether I can find time to review it before then. At this stage, I'm not sure if that's going to happen. |
@derekriemer, is this something you still would like to be included into core? Should I assign you to this issue, or should I close this, and the attachment be included in a PR? |
This may or may not be relevant to this issue.
Sometimes, when, for example downloading an update for a portable version
of nvda through firefox launched by nvda, download will almost end, but not
quite.
apparently firefox is putting up a message saying this is not a file which
is normally downloaded and wants to know if you want to finish it. This is
apparently not seen by nvda, though if you suspect this is why its stopped,
the context menu key does present options in the list to continue
downloading. I'm not quite sure why the download window alert is not being
seen by nvda. This seems to be a recent 'innovation' in Firefox 55.
I imagine due to the complex file names used for snapshots its trying to be
clever. If there is a way to switch this off in firefox I've not found it
yet.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
I saw this. I don't know what this is supposed to mean, because it's just weird. |
I think what they are trying to do is tell people that a file is not liked
for some reason, but maybe its just the complex name of snapshots that
sometimes triggers the warnings. Its a shame nobody gets to hear it when as
the original ticket says, all though a download all the details of that file
are repeated as if its all being refreshed as the progress bar moves. The
way to stop this seems to be to move away to another file, but since each
firefox session in the download list only has the files in it downloaded in
that session this cannot be done for the first download as you cannot cursor
to an older one.
Strangely in XP this is not a problem as you can see previous downloads.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
----- Original Message -----
From: "Derek Riemer" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Brian Gaff" <bglists@blueyonder.co.uk>; "Comment"
<comment@noreply.github.com>
Sent: Saturday, September 02, 2017 9:29 PM
Subject: Re: [nvaccess/nvda] in Mozilla Firefox Downloads window, NVDA
repeats the information associated to the file being downloaded each time
the download progress is updated (#4417)
…I saw this. I don't know what this is supposed to mean, because it's just
weird.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#4417 (comment)
|
No, I have seen your issue with the try build I triggered the other night. It's just strange. |
Maybe somebody could ask Mozilla what this new feature is all about. I've
only thus far seen it on nvda downloads of snapshots. Even File Hippo where
you can download huge numbers of files seems to not trigger it.
Incidentally, I've read all of this thread over the years, and wondered why
the author of the most successful patch did not just make it into an add-on
so many could test it and see if it had any drawbacks?
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
It's just not an issue any more unless the top file is focused. |
It is irritating though, if its the first download in a session as the older
files are not seen in the default view in that case.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal email to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
|
@derekriemer are you planning to raise a PR with the coresponding patch? Thank you very much for your work. |
Hi, Er, @jcsteh, is this something that might be doable from Mozilla side as well? CC @MarcoZehe |
I'm not sure how we could "fix" this in Firefox. The name of the list item is changing, so we fire a nameChange event accordingly. If we didn't do this, as an example, braille wouldn't update the name. A real fix for this would probably require some standardised way to indicate to a screen reader that this name shouldn't be "spoken" when it changes, but that feels pretty screen reader specific; we'd need a semantic abstraction for that. |
A solution could be possible I guess if braille and speech can behave differently from an output perspective. At least this is how it works in Jaws. Braille outputs instantly and speech does it only when moving the focus away and then back on the item. |
Reported by blindbhavya on 2014-08-25 10:10
Steps to reproduce
Download something (preferably big that may take enough download time to investigate and reproduce the issue successfully).
Press Ctrl + J and ensure that your focus is on the window named Libraries.
Now listen to NVDA repeating what is mentioned in the summary line of this ticket.
Is this an NVDA issue or an FX one?
I am using FX 31
The text was updated successfully, but these errors were encountered: