Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscDeps: Make executable files executable in git #4456

Closed
nvaccessAuto opened this issue Sep 14, 2014 · 3 comments
Closed

miscDeps: Make executable files executable in git #4456

nvaccessAuto opened this issue Sep 14, 2014 · 3 comments

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2014-09-14 10:47
Currently, executable files aren't set as executable in the miscDeps git repository. I don't think this is a problem for those using Windows git, but if you're using Cygwin git, core.filemode is true by default and these files really do become non-executable. We should make all dll, exe and pyd files executable to avoid this and it's probably the right ting to do anyway.

This can be done using this command:

git update-index --chmod=+x fileName

You can confirm the change with git ls-tree. Thanks to this post for the tip.

This should wait until wxPython 3 (#3763) and new Handy Tech files (#3709) are merged to avoid merge pain.
Blocked by #3709, #3763

@nvaccessAuto
Copy link
Author

Comment 1 by bdorer on 2015-07-24 20:43
the tickets mentioned aboove are fixed so this ticked could be fixed with no merge pain I think.

@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2015-07-27 01:12
In [18b1a87]:

miscDeps: Make executable files executable in the repository.

This should make life easier for those using Cygwin git.
Fixes #4456.

Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2015-07-27 01:12
Changes:
Milestone changed from None to 2015.3

@nvaccessAuto nvaccessAuto added this to the 2015.3 milestone Nov 10, 2015
jcsteh added a commit that referenced this issue Nov 23, 2015
This should make life easier for those using Cygwin git.
Fixes #4456.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant