Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing NVDA+q to exit NVDA will leave the NVDA icon in system tray. #4460

Closed
nvaccessAuto opened this issue Sep 16, 2014 · 35 comments
Closed

Comments

@nvaccessAuto
Copy link

Reported by vgjh2005 on 2014-09-16 04:27
Hi:
Pressing hotkey to exit NVDA will leave the NVDA icon in system tray. Pressing ctrl+alt+n to restart NVDA, this is also existing.
Thanks!

@nvaccessAuto
Copy link
Author

Comment 1 by driemer.riemer@... on 2014-09-16 04:44
I can confirm this.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2014-09-16 05:19
This suggests NVDA is not exiting correctly. Please try with all add-ons disabled. If the problem doesn't occur then, it is caused by an add-on.

@nvaccessAuto
Copy link
Author

Comment 3 by vgjh2005 on 2014-09-16 05:50
Hi:
I don't install any addon for NVDA. If right click the system icon then click exit command, and the icon will be disappearance.
Thanks!

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2014-09-16 06:05
That's odd. Does this only occur in next (and not on master or release)?

@nvaccessAuto
Copy link
Author

Comment 5 by vgjh2005 on 2014-09-16 06:11
Hi:
It occur in only next.
However the reason is updating of Wx_Python. Thanks.

@nvaccessAuto
Copy link
Author

Comment 6 by driemer.riemer@... on 2014-09-16 06:59
It has happened since at least 2012.

@nvaccessAuto
Copy link
Author

Comment 7 by briang1 on 2014-09-16 07:04
It is true it used to happen a lot, but at the moment in the main its only next which does it. I had thought this issue had gone away, but then I use mostly portablewversions of the other branches and the release version, so maybe there is a subtle difference between how its run and what it does.
At the moment it also causes the issue in next if you use a command line to terminat nvda in a batch file instead of the actual keys themselves.

If you attempt to use any of the extra versions of nvda in the tray, the icon will vanish and nothing will happen.

@nvaccessAuto
Copy link
Author

Comment 8 by jteh (in reply to comment 6) on 2014-09-16 08:10
Replying to driemer.riemer@…:

It has happened since at least 2012.

In normal circumstances, it definitely doesn't happen in recent releases. It's possibly broken in next, though. If it's happening all the time for you, it's very probably due to an add-on. It'd be great if you can check NVDA 2014.3 with all add-ons disabled. If it still happens then, we'll need to figure out why it behaves that way on your system.

@nvaccessAuto
Copy link
Author

Comment 9 by vgjh2005 on 2014-09-16 11:35
Hi:
I clear profile and uninstall next version at first, then reinstall NVDA2014.3. Pressing NVDA+q then yes button to exit NVDA will lose the icon without changing any setting and any addon in system tray. So NVDA2014.3 is normal.
Thanks!

@nvaccessAuto
Copy link
Author

Comment 10 by blindbhavya on 2014-09-17 14:33
Hi.
On my system, (Windows 7 Ultimate 32 bit) the NVDA icon is present in the System Tray > Notification Chevron button.
Is this where the icon is present normally?
I am asking this because here you all say that the NVDA icon is in the System Tray itself.
Please clarify.
Also, I was wondering, how can an add-on interfere in how the user quits NVDA, and possibly cause issues.
Hope someone can clarify my doubts.
If you would like to mail me personally without changing the direction of this thread, then my e-mail address is bhavya.shah125@gmail.com
I would appreciate any assistance.

@nvaccessAuto
Copy link
Author

Comment 12 by jteh (in reply to comment 10) on 2014-09-17 14:41
Replying to blindbhavya:

On my system, (Windows 7 Ultimate 32 bit) the NVDA icon is present in the System Tray > Notification Chevron button.

You can configure what icons get shown in the main notification area and which don't. See the Taskbar settings.

Also, I was wondering, how can an add-on interfere in how the user quits NVDA, and possibly cause issues.

An add-on can do almost anything.

@nvaccessAuto
Copy link
Author

Comment 13 by driemer.riemer@... on 2014-09-17 17:58
Something is wrong here on my machine with this then. I have isolated out all global plugins and addons and the problem persists.
Do I need to test with installed copies?

@nvaccessAuto
Copy link
Author

Comment 14 by jteh (in reply to comment 13) on 2014-09-17 20:50
Replying to driemer.riemer@…:

Something is wrong here on my machine with this then. I have isolated out all global plugins and addons and the problem persists.

I assume you mean it happens with 2014.3 as well? I also assume you made sure to clear icons from previously broken copies before testing 2014.3.

Do I need to test with installed copies?

Portable copies should be fine. Source should be fine too, as long as you're doing a full submodule update, scons source, etc.

@nvaccessAuto
Copy link
Author

Comment 15 by James Teh <jamie@... on 2014-09-18 03:47
In [1594ced]:

Ensure that the NVDA Notification Area icon gets cleaned up properly.

We now seem to need another iteration of the main loop in order for the TaskBarIcon to be destroyed properly. The documentation does seem to suggest that Destroy runs in a subsequent loop iteration, but we didn't need this before wxPython 3 for some reason.
Unfortunately, the loop has already exited by the time we destroy things. ProcessPendingEvents doesn't seem to work; Pending() even reports False after the destroy. Thankfully, calling MainLoop again does work and it returns quickly because the top window has been destroyed.
Re #4460.

@nvaccessAuto
Copy link
Author

Comment 16 by James Teh <jamie@... on 2014-09-18 03:47
In [862ef3d]:

Merge branch 't3763' into next

Incubates #3763. Fixes #4460.

Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 18 by vgjh2005 on 2014-10-23 01:42
Hi:
that Restart NVDA automatically after installing plugin package will still leave notification icon. Thanks!

@nvaccessAuto
Copy link
Author

Comment 19 by jteh (in reply to comment 18) on 2014-10-23 02:48
Replying to vgjh2005:

that Restart NVDA automatically after installing plugin package will still leave notification icon.

What exact build are you using? I can't reproduce this here with latest next (e14c2ff).

@nvaccessAuto
Copy link
Author

Comment 20 by vgjh2005 on 2014-10-23 06:57
Hi:
Please install resourceMonitor-3.1 and controlUsageAssistant consecutive. NVDA will restart twice and icon will be leaved.
Thanks!

@nvaccessAuto
Copy link
Author

Comment 21 by jteh on 2014-10-23 07:29
You didn't specify the build you are using.

@nvaccessAuto
Copy link
Author

Comment 22 by vgjh2005 (in reply to comment description) on 2014-10-25 06:33
Hi: I use the latest build next-11184,aedd1a3

@nvaccessAuto
Copy link
Author

Comment 23 by vgjh2005 on 2014-10-31 02:01
Changes:
State: reopened

@nvaccessAuto
Copy link
Author

Comment 24 by jteh (in reply to comment 20) on 2014-12-19 06:53
Replying to vgjh2005:

Please install resourceMonitor-3.1 and controlUsageAssistant consecutive. NVDA will restart twice and icon will be leaved.

I think I hopefully fixed this (6799a05). Can you please try the 19 December next snapshot? (It will be available a few hours after I write this.)

@nvaccessAuto
Copy link
Author

Comment 25 by vgjh2005 on 2014-12-20 06:03
Thanks Jimmy. It has been fixed.

@nvaccessAuto
Copy link
Author

Comment 26 by vgjh2005 on 2014-12-20 06:04
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 27 by vgjh2005 on 2014-12-24 02:03
Hi:
I made some test. I find that if NVDA didn't be restarted immediately by itself, for example this process is wait for three seconds, NVDA will be forced to kill. So this icon is leaved again in the last next version.
So I will reopen this ticket. Thanks!

@nvaccessAuto
Copy link
Author

Comment 28 by vgjh2005 on 2014-12-24 02:03
Changes:
State: reopened

@nvaccessAuto
Copy link
Author

Comment 29 by jteh (in reply to comment 27) on 2014-12-24 06:28
Replying to vgjh2005:

I made some test. I find that if NVDA didn't be restarted immediately by itself, for example this process is wait for three seconds, NVDA will be forced to kill.

Right, but how are you actually reproducing this? That shouldn't happen in normal usage. Are you saying it still happens when restarting after installing an add-on?

There is no way we can remove the icon if NVDA is killed instead of exited gracefully. That's just how Windows works. The question is why it isn't exiting gracefully.

@nvaccessAuto
Copy link
Author

Comment 30 by vgjh2005 on 2014-12-24 15:23
Hi Jamie:
You are right. You should install several addons consecutive. It has no regular at all. I don't know why NVDA will not be exited correctly. However it isn't associate with addons. Because it will be caused in not spasific addons at any time. Thanks!

@nvaccessAuto
Copy link
Author

Comment 31 by jteh (in reply to comment 30) on 2015-01-06 03:55
Replying to vgjh2005:

However it isn't associate with addons. Because it will be caused in not spasific addons at any time.

NVDA failing to exit correctly can absolutely be caused by add-ons. Have you tested this with all add-ons disabled?

Also, in comment:25, you said this was fixed, but you said it wasn't fixed in comment:27. So are you saying you're still seeing exactly the same issue and it wasn't fixed after all?

@nvaccessAuto
Copy link
Author

Comment 32 by vgjh2005 on 2015-01-07 01:45
Hi:
This problem is fixed in comment 25, then caused in the version that the comment 27 is committed. If this is caused by spacific addon, NVDA will be forced to kill all the time whenever whatever addons was installed after installing that questionable addon. But I cannot find the regular that the problem is caused.

@nvaccessAuto
Copy link
Author

Comment 33 by jteh on 2015-01-09 02:09
Okay. I can't reproduce this any more and no one else has reported it. We'll leave this open in case we can track it down, but it won't block #3763 from being merged into master.

@nvaccessAuto
Copy link
Author

Comment 34 by vgjh2005 on 2015-03-25 12:29
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 35 by vgjh2005 on 2015-03-25 12:32
Hi:
This problem has been fixed, despite I don't know what time it is.Thanks jteh!

@nvaccessAuto
Copy link
Author

Comment 36 by mohammed on 2015-05-02 17:06
when updating NVDA 2 system tray icons would become present. happens on both of my machines. currently running master.

why can't I re-open this ticket?

@nvaccessAuto
Copy link
Author

Comment 37 by jteh on 2015-05-03 05:11
Please open a new ticket for this. Thanks.

jcsteh added a commit that referenced this issue Nov 23, 2015
We now seem to need another iteration of the main loop in order for the TaskBarIcon to be destroyed properly. The documentation does seem to suggest that Destroy runs in a subsequent loop iteration, but we didn't need this before wxPython 3 for some reason.
Unfortunately, the loop has already exited by the time we destroy things. ProcessPendingEvents doesn't seem to work; Pending() even reports False after the destroy. Thankfully, calling MainLoop again does work and it returns quickly because the top window has been destroyed.
Re #4460.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant