New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assign Ctrl S keystroke to Save As command in NVDA Log Viewer #4532
Comments
Comment 2 by nvdakor on 2014-10-07 06:08 |
Comment 3 by jteh on 2014-10-07 06:20 |
Comment 4 by Joseph Lee <joseph.lee22590@... on 2014-10-07 06:26
|
Comment 5 by nvdakor on 2014-10-07 06:29 |
Comment 6 by nvdakor (in reply to comment 3) on 2014-10-07 06:41
Found it: in the menu entry name portion, it would be:
The tab character may show up as backslash t. The issue is that save as command is bound to WX_SAVEAS constant, which gets translated automatically to all supported languages. Adding a translatable string for the save as menu entry would be trivial, as it allows defining the accelerator along with the command (translators should be told not to change Control+S shortcut though). |
Comment 7 by Joseph Lee <joseph.lee22590@... on 2014-10-07 06:53
|
Comment 8 by jteh on 2014-10-07 07:03 |
Comment 9 by nvdakor (in reply to comment 8) on 2014-10-07 07:14
Done - WX accepts Ctrl+S (follows MS conventions). |
Hi guys, Pretty sure &As will bind to a not s. Shouldn't that be "save A&s"? That's how I did it in wx last time I did this sort of work. |
|
|
Oh, and the reason I bound it to "s" instead of "a" in the first place is that there is no plain "save" for the log viewer. |
Regarding (1), I wasn’t aware of that as I tend to open the log externally. That kinda voids my point. :) From: James Teh [mailto:notifications@github.com]
— |
…ntrol+s. Also, the accelerator in the menu is now a instead of s, as is more standard. Fixes #4532.
Incubated in 79a5a2d. |
Reported by blindbhavya on 2014-10-06 14:44
The summary line explains it all.
So, could Ctrl + S be made to work as the access key for the Save As option in the Log menu in the Log Viewer found in Tools submenu under NVDA Menu?
The text was updated successfully, but these errors were encountered: