New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support scancodes for keyboards connected to brailledisplays #4576
Comments
Comment 2 by jteh on 2014-10-27 09:29 For these types of keyboards, I think it makes sense to just have them use keyboardHandler.KeyboardInputGesture (which is what is used for the system keyboard), rather than a BrailleDisplayGesture subclass. Is there any reason this isn't acceptable? |
Comment 3 by halim on 2014-10-29 15:00
How can I use the keyboardinputgesture with this stuff? |
Comment 4 by jteh (in reply to comment 3) on 2014-10-30 01:54
Windows keyboard input deals with scan codes from scan code set 1. This means a key is either extended or it isn't. If this display specifies two types of extended key, this is a different scan code set and can't use NVDA's keyboard support. Regardless, you'll need to know what spec is being used for the scan codes. There are three sets of scan codes for PC keyboards and yet another for USB keyboards. Windows applications see PC keyboard scan code set 1.
If it does use set 1, we'll need to tweak KeyboardInputGesture so it can translate a scan code to a vk code using Windows API calls. Once it can do that, you'd just construct KeyboardInputGesture with the appropriate arguments and execute it as you would any other gesture. As above, if it doesn't use set 1, you'll have to write your own implementation from scratch. |
Comment 5 by halim on 2014-11-07 11:50 |
Comment 6 by jteh on 2014-11-11 02:32 I think the best way we can handle this is to introduce a keyboardHandler.injectRawKeyboardInput(isPress, scanCode, isExtended) function. This will use keyboardHandler's internal hook callbacks and send the raw key to the OS if appropriate. |
Comment 7 by James Teh <jamie@... on 2014-11-11 03:46
|
Comment 8 by jteh on 2014-11-11 03:48 |
Comment 9 by jteh on 2014-11-11 10:32
|
Comment 10 by halim on 2014-11-12 13:57 |
Comment 11 by halim on 2014-11-25 08:34 |
Comment 12 by halim on 2014-11-25 13:52
|
Comment 13 by halim on 2014-11-25 15:30
|
Comment 14 by halim on 2014-11-27 20:59 The bigest issue for now is why nvda reports leftwin rightwin and application key correct but doesn't trigger any aktion in windows? |
Comment 15 by jteh on 2014-12-02 02:32 |
Comment 16 by halim (in reply to comment 15) on 2014-12-04 09:40
Thx! Here is a new summary of the known issues:
|
Comment 17 by nvdakor on 2015-01-07 10:41
|
Comment 18 by nvdakor on 2015-01-13 07:22
|
Comment 19 by jteh on 2015-01-13 07:28 Having said that, it might be better to map the BrailleNote QWERTY stuff to keyboardHandler.KeyboardInputGesture so it can benefit from NVDA's actual keyboard bindings, as this is meant to simulate a true keyboard. This is aprticularly true if BrailleNote uses Windows vk codes (I vaguely seem to recall this), as KeyboardInputGesture can do the mapping for you. Anyway, let's discuss that on the new ticket. |
Comment 20 by halim on 2015-01-27 07:49 |
Comment 21 by jteh on 2015-01-27 08:25 |
Comment 22 by halim (in reply to comment 7) on 2015-02-25 10:24
What about merging that for 2015.2? |
Comment 23 by jteh on 2015-02-25 10:50 |
Comment 24 by halim (in reply to comment 23) on 2015-02-27 07:01
Ok this makes sense. Perhaps the function needs an aditional boolean parameter which specifies the given code. |
Comment 25 by halim on 2015-04-18 12:36 |
Comment 26 by jteh on 2015-04-20 06:32 I think I've fixed the problems with the alt/Windows/applications keys in b210f340. Note that according to Microsoft documentation, doing this for extended keys only works on Windows Vista and later. There's nothing I can do about this. |
Comment 27 by jteh on 2015-04-20 06:36 |
Comment 28 by halim on 2015-04-23 06:59 |
Comment 29 by jteh on 2015-05-11 04:22 |
Comment 33 by James Teh <jamie@... on 2015-06-29 01:46
Changes:
|
Comment 34 by James Teh <jamie@... on 2015-07-14 06:01
Changes:
|
…d natively by Windows (e.g. a QWERTY keyboard on a braille display) using the new keyboardHandler.injectRawKeyboardInput function. Fixes #4576.
Reported by halim on 2014-10-27 08:39
Currently nvda supports only dot combinations for brailleinput. There are some displays which have a qwerty keyboard connected to the brailledisplay or are build in.
The input code should support scancodes as well. This would make it easy to support these displays.
Supporting a brailledisplay with build-in qerty keyboard needs Currently translate scancodes to dots and nvda has to backtranslate it etc, which isn't optimal.
Blocking #5181
The text was updated successfully, but these errors were encountered: