Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for papenmeier braille driver #4614

Closed
nvaccessAuto opened this issue Nov 10, 2014 · 13 comments
Closed

update for papenmeier braille driver #4614

nvaccessAuto opened this issue Nov 10, 2014 · 13 comments
Assignees
@jcsteh
Labels
bug component/braille
Milestone
2015.1

Comments

@nvaccessAuto
Copy link

Reported by halim on 2014-11-10 07:01
An updated version of the papenmeier brailledriver is available.
Changes are:

  • Support new braille displays (Braillex live 20, Braillex Live, Braillex Live+)
    bugfixes:
  • Braillex keys working again when using nvda with brxcom
  • other smaller fixes.

I.ll post two patches soon. One provided by aliminator for documentation. Second one is the patch to current git version of the papenmeier driver.

Thx.
@nvaccessAuto
Copy link
Author

Attachment doku.patch added by halim on 2014-11-10 09:39
Description:
this is the dokumentation patch from aliminator

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2014-11-10 22:47
If the "other fixes" are noticeable to users, please be more specific about what they are. This way, a user will know if a problem they were experiencing has been fixed. If they're just minor code improvements, they don't affect users directly and don't need to be mentioned. Thanks.

@nvaccessAuto
Copy link
Author

Attachment patch added by halim on 2014-11-12 07:50
Description:
update diff

@nvaccessAuto
Copy link
Author

Comment 2 by James Teh <jamie@... on 2014-11-17 07:33
In [c56943f]:

When using a Papenmeier BRAILLEX braille display with BrxCom, keys on the display now work as expected.

Re #4614.

@nvaccessAuto
Copy link
Author

Comment 3 by jteh on 2014-11-17 07:38
I've committed a patch to fix the major bug (BrxCom key handling) for NVDA 2014.4, as the full patch cannot be accepted at this late stage. Please still provide the additional details requested in comment:1 so we can include the full patch in NVDA 2015.1. Thanks.

@nvaccessAuto
Copy link
Author

Comment 4 by halim on 2014-11-17 07:44
Well the other fixes are not noticeable for other users.
Removed some hardcoded values wich produced errors with the new added displays etc.

@nvaccessAuto
Copy link
Author

Comment 5 by halim on 2015-01-13 07:07
nvda 2015.1 makes progress :-). Could you please apply the complete patch now?

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2015-01-13 07:16
Changes:
Milestone changed from None to 2015.1

@nvaccessAuto
Copy link
Author

Comment 7 by James Teh <jamie@... on 2015-01-16 06:28
In [7616a1a]:

Support for the Papenmeier BRAILLEX Live 20, BRAILLEX Live and BRAILLEX Live Plus braille displays.

Re #4614.
Documentation updates by Ali-Riza Ciftcioglu aliminator83@googlemail.com

@nvaccessAuto
Copy link
Author

Comment 8 by James Teh <jamie@... on 2015-01-16 06:29
In [be0c198]:

Merge branch 't4614' into next

Incubates #4614.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 9 by aliminator on 2015-01-16 07:37
The entry for the changelog is missing when checking this out from git although it is in the patch.
Its the following entry:

  • New Papenmeier displays are supported: BRAILLEX Live 20, BRAILLEX Live and BRAILLEX Live Plus.

@nvaccessAuto
Copy link
Author

Comment 10 by jteh on 2015-01-16 07:46
We don't include What's New entries in topic branches/next because they almost always cause annoying merge conflicts when we merge to master. Thus, we just add the What's New entry during the merge to master. Thanks.

@nvaccessAuto
Copy link
Author

Comment 11 by James Teh <jamie@... on 2015-01-30 05:25
In [0b6c5d7]:

Support for the Papenmeier BRAILLEX Live 20, BRAILLEX Live and BRAILLEX Live Plus braille displays.

Fixes #4614.
Documentation updates by Ali-Riza Ciftcioglu aliminator83@googlemail.com

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015
jcsteh pushed a commit that referenced this issue Nov 23, 2015
@jcsteh
Support for the Papenmeier BRAILLEX Live 20, BRAILLEX Live and BRAILL…
0b6c5d7 
…EX Live Plus braille displays.

Fixes #4614.
Documentation updates by Ali-Riza Ciftcioglu <aliminator83@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
bug component/braille
Projects
None yet
Milestone
2015.1
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto