New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Braille trace to update selected line message #4682
Comments
Comment 1 by jteh on 2014-12-11 02:57 |
Comment 2 by surfer0627 (in reply to comment 1) on 2014-12-12 03:00
Yes, this is a temperate solution. |
Comment 3 by dkager on 2015-10-19 18:41
|
Another problem of the current implementation of braille.TextInfoRegion.update() is that it restricts itself to the line that contains the cursor. This prevents translating text into braille that the user can't scroll to without moving the cursor. We need to extend this so it moves to the active end of the selection, if any. Code to find the active end is part of #5770. |
@jcsteh In braille.TextInfoRegion.update() I read:
This is only used near the end of the function:
Why does this not use self.obj.makeTextInfo? It would simplify the code a bit if this could be avoided. If not it'd be great if the comment could be a bit clearer. |
The comment you reference isn't at all related to the question you're
asking. That doesn't mean we shouldn't add another comment though. :)
The reason is that self._getCursor might not return something created by
self.obj directly. For example, ReviewTextInfoRegion._getCursor returns
api.getReviewPosition(). We want to be sure we're always using the same
object to make all TextInfos, even if _getCursor returned something from
a different object for some reason.
|
Those are the very best questions! |
Oh. Now I see what you mean. So yes, readingInfo.obj and cursor.obj are
equal, but you originally mentioned self.obj, which might not be equal.
Once upon a time, cursor was used instead of sel (before we supported
selection for braille). Now that it isn't, there's no need for cursor
once it's copied, but apparently, I never removed it. :)
|
According to deaf blind community in Japan, people who uses only braille display cannot check the ending character of selected text region, when the region contains several lines. step to reproduce:
The workaround for this is firstly move to the ending of the region, and then, use shift + left arrow to increase the region in reverse. however, it is not intuitive. Is this duplicate of #5770 or here? |
I believe I initially wanted to do the selection code in two steps: first for left/right selections on a single line in #5770 and then multi-line selections in this issue. But in the end I did both, so yes this is fixed. |
Reported by surfer0627 on 2014-12-11 02:47
Hi,
Now, when user press shift+arrow down (few times) to select messages. Braille always update the first line.
expected: braille trace to update the selected line.
STR:
Here is a message cut in three lines.
Text message:
BlindSquare is the World’s Most Popular accessible GPS-app developed for the blind and visually
impaired. It describes the environment, announces points of interest and street intersections as
you travel. In conjunction with free, third-party navigation apps it is a powerful solution
When pressing shift+arrow down (two times) to select lines, braille update the first line: "BlindSquare is the World’s Most Popular accessible GPS...".
expected: Braille updates the second line: "impaired. It describes the environment, announces points ..."
Thanks.
The text was updated successfully, but these errors were encountered: