Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows 10: Target Windows 10 via app manifest #4760

Closed
nvaccessAuto opened this issue Dec 29, 2014 · 9 comments
Closed

Windows 10: Target Windows 10 via app manifest #4760

nvaccessAuto opened this issue Dec 29, 2014 · 9 comments

Comments

@nvaccessAuto
Copy link

Reported by nvdakor on 2014-12-29 22:22
Hi,
Spin-off from #3793:
The fix for #3793 also applies to Windows 10: it has its own GUID (globally unique identifier). Various comments inMSDN articles says the GUI is:

Microsoft intends to use GUID's to test for OS targeting, according to a remark in MSDN article on version helper API's.
Reference:

@nvaccessAuto
Copy link
Author

Comment 1 by nvdakor on 2014-12-29 22:31
Hi,
GUID added:

  • URL: https://bitbucket.org/josephsl/nvda-dev
  • Branch: t4760
  • Commit: a3193ab
    There might be some submodule commits as well. Also updated copyright year. The diff was tested with Windows 10 Tech Preview and Windows 10 does tell NvDA that it is Windows 10.
    Thanks.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2015-01-05 23:09
Thanks. Why submodule commits? This shouldn't touch submodules.

@nvaccessAuto
Copy link
Author

Comment 3 by nvdakor on 2015-01-05 23:12
Hi,
Oops - I guess I'll need to clone the repo again to refresh the submodules (my apologies again).
Thanks.

@nvaccessAuto
Copy link
Author

Comment 4 by nvdakor on 2015-01-05 23:15
Hi,
There might have been submodule commits, as I based the GUID branch from latest master at that time. If there are any submodule commits, then I'll try to start over from a fresh repo.

@nvaccessAuto
Copy link
Author

Comment 5 by Joseph Lee <joseph.lee22590@... on 2015-02-20 06:14
In [a3193ab]:

Target Windows 10 using its GUID. re #4760
Starting with Windows 8.1, Microsoft recommends developers to use ap manifests to specify OS compatibility instead of relying on version info tuple (which Python returns via Windows API). This was used for fixing ticket 3793 (targeting Windows 8.).
This also applies to Windows 10 in that it has its oww GUID. Without this Windows 10 tells NVDA that it is Windows 8.1 (NT6.3, not NT6.4/10.0). Thus the new GUID for Windows 10 was added to declare that NVDA supports Windows 10.

@nvaccessAuto
Copy link
Author

Comment 6 by James Teh <jamie@... on 2015-02-20 06:14
In [b9e6bc1]:

Merge branch 't4760' into next

Incubates #4760.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 7 by jteh on 2015-02-20 06:36
Thanks. All good; no submodule commits.

@nvaccessAuto
Copy link
Author

Comment 8 by James Teh <jamie@... on 2015-03-26 05:27
In [d11134d]:

Target Windows 10 in NVDA's application manifest.

This means that correct Windows version information will be reported on Windows 10.
Fixes #4760.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto
Copy link
Author

Comment 9 by jteh on 2015-03-26 05:28
Changes:
Milestone changed from None to 2015.2

@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015
josephsl added a commit that referenced this issue Nov 23, 2015
This means that correct Windows version information will be reported on Windows 10.
Fixes #4760.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants