Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting to not jump into focus mode when quick navigation keys are pressed #4767

Closed
nvaccessAuto opened this issue Jan 2, 2015 · 3 comments
Closed

Add setting to not jump into focus mode when quick navigation keys are pressed #4767

nvaccessAuto opened this issue Jan 2, 2015 · 3 comments
Labels
enhancement feature/browse-mode

Comments

@nvaccessAuto
Copy link

Reported by jscholes on 2015-01-02 13:14
Since the changes to browse mode were implemented (perhaps starting with changeset 9f35672), focus mode is now activated when, for example, an edit field is encountered after pressing E or F.

While this is consistent with the idea of automatic focus mode changes for caret movement, a lot of users, including myself, will enjoy focus mode being activated automatically when using the arrows, but would still like to be able to quickly move through form fields using quick navigation keys. I would request that a setting be added to the browse mode settings dialog to allow this.
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2015-01-06 07:48
This was not an intended or expected change, nor can I reproduce it here. Please provide further information, including a test case, browser used, exact NVDA version, focus mode settings, etc.

@nvaccessAuto
Copy link
Author

Comment 2 by jscholes on 2015-01-06 12:54
NVDA version: next-11426,4a78c9f
Test case URL: http://www.freedomscientific.com/Training/Surfs-Up/WebTrack.htm
Browser used: Firefox 34.0.5 running on Windows 7
Browse mode configuration: Automatic focus mode for focus changes enabled, Automatic focus mode for caret movement enabled, Use screen layout (when supported) not enabled, Automatic Say All on page load not enabled, Include layout tables not enabled, Trap all non-command gestures from reaching the document enabled.

The debug log to show the results when I visit the above page and use E and F to jump to the first two edit fields is below. You'll see that focus mode is activated automatically and that I have to press escape to move back to browse mode in order to use further quick navigation keys. Note also that this problem occurs with all add-ons disabled via the --disable-addons command line option.

DEBUG - treeInterceptorHandler.update (12:47:23):
Adding new treeInterceptor to runningTable: <virtualBuffers.gecko_ia2.Gecko_ia2 object at 0x04F03210>
IO - speech.speak (12:47:23):
Speaking [mode'](u'browse)
IO - speech.speak (12:47:23):
Speaking [New WebTrack Sample Call Tracking System  document'](u'The)
IO - speech.speak (12:47:23):
Speaking [ level 1', u'The New WebTrack'](u'heading)
IO - inputCore.InputManager.executeGesture (12:47:25):
Input: kb(laptop):e
IO - speech.speak (12:47:25):
Speaking [ edit  has auto complete'](u'Name:)
IO - speech.speak (12:47:25):
Speaking [mode'](u'focus)
IO - speech.speak (12:47:26):
Speaking [Information   grouping'](u'Contact)
IO - speech.speak (12:47:26):
Speaking [ edit  has auto complete'](u'Name:)
IO - speech.speak (12:47:26):
Speaking [- inputCore.InputManager.executeGesture (12:47:30):
Input: kb(laptop):escape
IO - speech.speak (12:47:30):
Speaking [u'browse mode'](u'blank']
IO)
IO - inputCore.InputManager.executeGesture (12:47:30):
Input: kb(laptop):f
IO - speech.speak (12:47:30):
Speaking [Number:  edit  has auto complete'](u'Phone)
IO - speech.speak (12:47:30):
Speaking [mode'](u'focus)
IO - speech.speak (12:47:30):
Speaking [Number:  edit  has auto complete'](u'Phone)
IO - speech.speak (12:47:30):
Speaking [- inputCore.InputManager.executeGesture (12:47:32):
Input: kb(laptop):escape
IO - speech.speak (12:47:32):
Speaking [u'browse mode'](u'blank']
IO)

@nvaccessAuto
Copy link
Author

Comment 3 by Michael Curran <mick@... on 2015-01-09 02:36
In [e7c90a3]:

Quick nav again no longer automatically turns on focus mode in virtualBuffers when jumping to an interactive element when Automatic focus mode for caret movement is turned on. Fixes #4767

 Specifically:
- browseMode.QuicknavItem.moveTo: now only handles the move, not the reporting. It also no longer takes any extra arguments.
  - added browseMode.QuickNavItem.report, which is called to report the item where moveTo would have also done this in the past. report takes a readUnit optional argument. The gesture argument is not needed at all as now the resumeSayAll check is done outside of the call to report in the quickNavScript code itself.
- VirtualBufferquickNavItem: overode moveTo method to correctly pass reason_quickNav when setting the selection so that focus mode is not inappropriately turned on.

Changes:
State: closed

michaelDCurran added a commit that referenced this issue Nov 23, 2015
@michaelDCurran
Quick nav again no longer automatically turns on focus mode in virtua…
e7c90a3 
…lBuffers when jumping to an interactive element when Automatic focus mode for caret movement is turned on. Fixes #4767

 Specifically:
 * browseMode.QuicknavItem.moveTo: now only handles the move, not the reporting. It also no longer takes any extra arguments.
* added browseMode.QuickNavItem.report, which is called to report the item where moveTo would have also done this in the past. report takes a readUnit optional argument. The gesture argument is not needed at all as now the resumeSayAll check is done outside of the call to report in the quickNavScript code itself.
 * VirtualBufferquickNavItem: overode moveTo method to correctly pass reason_quickNav when setting the selection so that focus mode is not inappropriately turned on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature/browse-mode
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvaccessAuto