Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new DocumentTreeInterceptor class as base for any TreeInterceptor that supports document review #4838

Closed
nvaccessAuto opened this issue Jan 22, 2015 · 3 comments
Closed

Introduce new DocumentTreeInterceptor class as base for any TreeInterceptor that supports document review #4838

nvaccessAuto opened this issue Jan 22, 2015 · 3 comments
Labels
enhancement

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2015-01-22 01:05
Some tree interceptors can support document review as they have a makeTextInfo method, though some don't. BrowseMode is not enough as a browse mode implementations such as for Excel #1987 will not have document review. CursorManager is also not enough as documPoundDocuments don't use cursorManager. Therefore we need a new DocumentTreeInterceptor class. This should have a default implementation of makeTextInfo and a TextInfo property that raises NotImplementedError
Blocking #1987
@nvaccessAuto
Copy link
Author

Comment 1 by Michael Curran <mick@... on 2015-01-22 01:58
In [2397a16]:

Merge branch 't4838' into next. Incubates #4838

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2015-04-10 01:27
This will be merged to master along with #1987.

@nvaccessAuto
Copy link
Author

Comment 3 by Michael Curran <mick@... on 2015-04-29 06:18
In [56cd8df]:

Merge branch 't4838'. Fixes #4838 and Fixes #4850

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto mentioned this issue Nov 10, 2015
Closed
michaelDCurran added a commit that referenced this issue Nov 23, 2015
@michaelDCurran
Merge branch 't4838'. Fixes #4838 and Fixes #4850
56cd8df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nvaccessAuto