Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSHTML: inappropriate content is rendered for nodes with visibility:hidden #4839

Closed
nvaccessAuto opened this issue Jan 22, 2015 · 3 comments
Closed

MSHTML: inappropriate content is rendered for nodes with visibility:hidden #4839

nvaccessAuto opened this issue Jan 22, 2015 · 3 comments
Labels
bug feature/browse-mode
Milestone
2015.1

Comments

@nvaccessAuto
Copy link

Reported by mdcurran on 2015-01-22 06:32
In the MSHTML VBufBackend: If a node is marked with visibility:hidden, its child text nodes are correctly not rendered. However, if after rendering its other node descendants yields no content in the virtualBuffer for that node, then we fal back to the node's accessible name or equivilant. We should not do this for nodes with visibility:hidden. This is causing NVDA to render large chunks of content such as collapsed navigation lists, or error messages, when they have been marked as visibility:hidden.
@nvaccessAuto
Copy link
Author

Comment 1 by Michael Curran <mick@... on 2015-01-22 06:36
In [c9f40bd]:

Merge branch 't4839' into next. Incubates #4839

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2015-01-22 21:24
This is one instance of #3776. Can this same idea be applied to fix other instances of hidden content?

@nvaccessAuto
Copy link
Author

Comment 3 by Michael Curran <mick@... on 2015-02-05 00:23
In [5c2b8d1]:

Merge branch 't4839'. Fixes #4839

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.1 milestone Nov 10, 2015
michaelDCurran added a commit that referenced this issue Nov 23, 2015
@michaelDCurran
Merge branch 't4839'. Fixes #4839
5c2b8d1
michaelDCurran added a commit that referenced this issue Nov 23, 2015
@michaelDCurran
Mention fixes for #4839 and #3776 in changes.t2t
3f9c526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/browse-mode
Projects
None yet
Milestone
2015.1
Development

No branches or pull requests
1 participant
@nvaccessAuto