Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only convert t2t for languages just committed #4924

Closed
nvaccessAuto opened this issue Feb 16, 2015 · 3 comments
Closed

Only convert t2t for languages just committed #4924

nvaccessAuto opened this issue Feb 16, 2015 · 3 comments
Assignees
@jcsteh
Labels
enhancement workflow/automated-translation

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-02-16 03:51
Currently, we are converting t2t files for all languages on every commit with a t2t file (regardless of language). It'd be better if we only converted the t2t files for the languages for which t2t files were modified. This should be a fairly simple matter of using convertOne.sh instead of convertT2t.sh for the appropriate languages, just as we do for poChecker.
Blocking #4945
@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2015-02-18 06:21
Better still, we should report any errors in the commit message, rather than sending a separate email for encoding errors. Currently, unless I'm missing something, we don't send anything at all for key commands generation errors.

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2015-02-25 05:26
I think I'm pretty much done with this. I implemented #4945 as part of this. However, I will be offline for a few weeks any time now, so I'll probably hold off on committing it until after I get back in case anything breaks.

@nvaccessAuto
Copy link
Author

Comment 7 by jteh on 2015-03-26 02:52
Fixed in SrtCommit:20941.
Changes:
State: closed

This was referenced Nov 10, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
enhancement workflow/automated-translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto