Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problems due to changes to typing indicator in Skype 7.2 #4972

Closed
nvaccessAuto opened this issue Mar 12, 2015 · 4 comments
Closed

Fix problems due to changes to typing indicator in Skype 7.2 #4972

nvaccessAuto opened this issue Mar 12, 2015 · 4 comments
Assignees
@jcsteh
Labels
app/skype Skype for desktop or Skype for business (linc) bug/regression bug
Milestone
2015.2

Comments

@nvaccessAuto
Copy link

Reported by PZajda on 2015-03-12 10:00
On gain/lost focus, and on menu bar, I have the following error:
error executing event: gainFocus on <NVDAObjects.IAccessible.ContentGenericClient object at 0x0B34F150> with extra args of {}
Traceback (most recent call last):
File "eventHandler.pyc", line 138, in executeEvent
File "eventHandler.pyc", line 151, in doPreGainFocus
File "api.pyc", line 134, in setFocusObject
File "appModuleHandler.pyc", line 223, in handleAppSwitch
File "appModules\skype.pyc", line 230, in event_appModule_loseFocus
File "appModules\skype.pyc", line 79, in lostFocus
AttributeError: 'Conversation' object has no attribute 'typingIndicator'
I also have this error with Alt+Tab.
Blocking #4964, #4991
@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2015-03-23 05:16
Changes:
Changed title from "Error on a lot of events with Skype 7.2.0.103" to "Fix problems due to changes to typing indicator in Skype 7.2"
Milestone changed from None to 2015.2

@nvaccessAuto
Copy link
Author

Comment 5 by James Teh <jamie@... on 2015-04-13 06:51
In [90583c7]:

Merge branch 't4972' into next

Incubates #4972.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 6 by James Teh <jamie@... on 2015-04-30 03:54
In [dfdcd21]:

In Skype for Desktop 7.2 and later, typing notifications are now reported and problems immediately after moving focus out of a conversation have been fixed.

Skype 7.2 changed the typing notification control. Aside from the obvious, this also caused an exception whenever a conversation lost focus.
Also, since Skype seem intent on changing things every couple of versions, if the output list and/or typing indicator can't be found, log a warning and try to handle this more gracefully.
Fixes #4972.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added bug app/skype Skype for desktop or Skype for business (linc) bug/regression labels Nov 10, 2015
@nvaccessAuto nvaccessAuto added this to the 2015.2 milestone Nov 10, 2015
@nvaccessAuto nvaccessAuto mentioned this issue Nov 10, 2015
Closed
jcsteh added a commit that referenced this issue Nov 23, 2015
@jcsteh
In Skype for Desktop 7.2 and later, typing notifications are now repo…
dfdcd21 
…rted and problems immediately after moving focus out of a conversation have been fixed.

Skype 7.2 changed the typing notification control. Aside from the obvious, this also caused an exception whenever a conversation lost focus.
Also, since Skype seem intent on changing things every couple of versions, if the output list and/or typing indicator can't be found, log a warning and try to handle this more gracefully.
Fixes #4972.
@nvaccessAuto nvaccessAuto mentioned this issue Aug 15, 2017
Closed
@Adriani90
Copy link
Collaborator

@ruifontes, @florianionascu7 can anyone of you reproduce this issue? I think it is fixed by the commit above but I just wanted a short confirmation from an user with last skype version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
app/skype Skype for desktop or Skype for business (linc) bug/regression bug
Projects
None yet
Milestone
2015.2
Development

No branches or pull requests
3 participants
@jcsteh @nvaccessAuto @Adriani90