Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Greek letter translations in zh-tw.ctb #5106

Closed
nvaccessAuto opened this issue May 24, 2015 · 4 comments
Closed

Wrong Greek letter translations in zh-tw.ctb #5106

nvaccessAuto opened this issue May 24, 2015 · 4 comments

Comments

@nvaccessAuto
Copy link

Reported by school510587 on 2015-05-24 19:51
Hi, developers,

My language is zh_TW, and I use zh-tw.ctb for Braille display.
However, there are 3 problems in translation of Greek letters.
This problem is actually about liblouis, one of NVDA's dependency.
I've tried to report it on liblouis* website, they suggested that I send my patch to liblouis-liblouisxml@freelists.org
But I didn't get any response... So I describe my problem and the solution (a patch) here.
Could you help me fix it (or communicate liblouis*)?
Thanks in advance.

I'm using NVDA 2015.1 on XP.

  1. On Greek letter Φ (uppercase Phi, unicode 03A6), NVDA shows 46-1257 dots.
    However, according to Greek Braille translation (gr-gr-g1.utb), Phi is 124.
    So the correct translation is 46-124, where 46 is a prefix for us to distinguish Greek letters from English letters.
  2. On Greek letter φ (lowercase phi, unicode 03C6), NVDA shows 46-125 dots.
    For the same reason that is stated in the previous problem, the correct translation is 46-124.
  3. On Greek letter θ (lowercase theta, unicode 03B7), NVDA shows its internal code directly.
    its correct translation is 46-1456, but this entry is missing in zh-tw.ctb.

Sorry, I'm new to this website, and please forgive my unstructured report.

The following is the link of my original bug report on liblouis*
http://liblouis.org/bugs/Wrong_Greek_alphabets_translation_in_zh-tw.ctb/

I checked "I have files to attach to this ticket", but I couldn't find the "..." or "Browse" button to upload my patch.
So I put it in the following link:
http://mail3.batol.net/~school510587/0001-Fix-greek-character-translations-in-zh-tw.ctb.patch

@nvaccessAuto
Copy link
Author

Attachment 0001-Fix-greek-character-translations-in-zh-tw.ctb.patch added by school510587 on 2015-05-24 19:54
Description:
This file is the same as what I mentioned in the report.

@nvaccessAuto
Copy link
Author

Comment 1 by nvdakor on 2015-05-24 20:28
Hi,
I'll forward your patch to LibLouis list on your behalf to be included in the next release or later. Thanks.

@nvaccessAuto
Copy link
Author

Comment 3 by school510587 (in reply to comment 1) on 2015-10-22 13:01
Replying to nvdakor:

I'll forward your patch to LibLouis list on your behalf to be included in the next release or later. Thanks.

Coscell Kao has fixed bugs of zh-tw.ctb according to many suggestions from Taiwanese users, and liblouis accepts his update in commit 7559d735030cc049c30c82e1c29d39784c2e0515.
These changes include the 3 characters mentioned above, so this ticket can be closed after upgrading liblouis version.
Thanks for your help!

@dkager
Copy link
Collaborator

dkager commented Feb 5, 2017

liblouis has long since been upgraded, this can be closed.

@jcsteh jcsteh closed this as completed Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants