Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to liblouis 2.6.3 #5137

Closed
nvaccessAuto opened this issue Jun 3, 2015 · 8 comments
Closed

Upgrade to liblouis 2.6.3 #5137

nvaccessAuto opened this issue Jun 3, 2015 · 8 comments

Comments

@nvaccessAuto
Copy link

Reported by jteh on 2015-06-03 01:07
liblouis 2.6.3 has now been released.

Aside from the submodule update, some stuff to consider:

  • Changes to Korean tables. Joseph, I see some tables got added, renamed, etc. What do you want done as far as the NVDA table list is concerned?
  • New table for Polish 8 dot computer braille.
  • New table for Vietnamese 6 dot.

We should consider doing #5097 while we're at it. Also, we should consider whether to switch to the new UEB tables again (#4194).
Blocking #5074, #5074, #5097

@nvaccessAuto
Copy link
Author

Comment 1 by nvdakor (in reply to comment description) on 2015-06-03 01:13
Replying to jteh:

  • Changes to Korean tables. Joseph, I see some tables got added, renamed, etc. What do you want done as far as the NVDA table list is concerned?

The existing Korean tables can be kept. I added two Korean tables: Korean Grade 1 (2006) and Korean Grade 2 (2006) with their respective file names. These tables were requested by Korean braille readers a few months back.

Also, we should consider whether to switch to the new UEB tables again (#4194).

I think it should be done as a separate branch/snapshot so we can have real-life feedback from UEB users. Be careful on UEB table set though: as you may know, Mike Gray from American Printing House for the Blind (APH) is working on enhancing the table, with previous UEB table maintainers (I and others) agreeing to use Mike's tables in the end with previous maintainers assisting the efforts such as providing tests, and in my case, putting a third-party snapshot to test the tables in NVDA.
Thanks.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh (in reply to comment 1) on 2015-06-03 01:20
Replying to nvdakor:

I added two Korean tables: Korean Grade 1 (2006) and Korean Grade 2 (2006) with their respective file names. These tables were requested by Korean braille readers a few months back.

Do you want these added to the NVDA table list?

I think UEB table switch should be done as a separate branch/snapshot so we can have real-life feedback from UEB users. ...

Agreed, though I think we should perhaps wait until a bit more work is done. It still sounds like no one really knows whether the new tables are satisfactory yet. Once we have a reasonable degree of certainty, we can merge into next for wider testing.

@nvaccessAuto
Copy link
Author

Comment 3 by nvdakor (in reply to comment 2) on 2015-06-03 01:22
Replying to jteh:

Replying to nvdakor:

I added two Korean tables: Korean Grade 1 (2006) and Korean Grade 2 (2006) with their respective file names. These tables were requested by Korean braille readers a few months back.

Do you want these added to the NVDA table list?

Yes please.

@nvaccessAuto
Copy link
Author

Comment 4 by dkager (in reply to comment description) on 2015-06-06 13:02
Replying to jteh:

We should consider doing #5097 while we're at it.

And maybe also #5074.

Also, we should consider whether to switch to the new UEB tables again (#4194).

There is still some work going on here as @nvdakor said. This includes some opcode changes and other internal work that I agree isn't quite ready yet (it's also not in the official distribution right now).

@nvaccessAuto
Copy link
Author

Comment 5 by jteh on 2015-06-06 22:41
Yes, we should consider #5074 as well. Thanks for raising that.

If I'm not mistaken, it looks like there is yet another set of UEB tables in the works now. That makes 3 sets of UEB tables. What an insane mess.

@nvaccessAuto
Copy link
Author

Comment 8 by James Teh <jamie@... on 2015-06-26 06:47
In [d0226c8]:

Merge branch 't5137' into next

Incubates #5137, #5097.

Changes:
Added labels: incubating

@nvaccessAuto
Copy link
Author

Comment 9 by James Teh <jamie@... on 2015-06-29 02:06
In [1571126]:

Merge branch 't5137' into next

Incubates #5137, #5074.

@nvaccessAuto
Copy link
Author

Comment 10 by James Teh <jamie@... on 2015-07-14 06:01
In [13dfe27]:

Update liblouis to 2.6.3 and add new braille tables.

Fixes #5137, #5074, #5097.

Changes:
Removed labels: incubating
State: closed

@nvaccessAuto nvaccessAuto added this to the 2015.3 milestone Nov 10, 2015
dkager added a commit to dkager/nvda that referenced this issue Nov 10, 2015
…s when specifying an invalid table. Requires liblouis >= 2.6.3 (nvaccess#5137).
dkager added a commit to dkager/nvda that referenced this issue Nov 13, 2015
…s when specifying an invalid table. Requires liblouis >= 2.6.3 (nvaccess#5137).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants